[phpwiki-checkins] SF.net SVN: phpwiki:[10250] trunk/lib/plugin/AuthorHistory.php

[<var...@us...>]

Revision: 10250
          http://sourceforge.net/p/phpwiki/code/10250
Author:   vargenau
Date:     2021-02-22 12:38:19 +0000 (Mon, 22 Feb 2021)
Log Message:
-----------
plugin AuthorHistory: better test boolean arguments "noheader", "includeminor" and "includedeleted"

Modified Paths:
--------------
    trunk/lib/plugin/AuthorHistory.php

Modified: trunk/lib/plugin/AuthorHistory.php
===================================================================
--- trunk/lib/plugin/AuthorHistory.php	2021-02-22 12:28:09 UTC (rev 10249)
+++ trunk/lib/plugin/AuthorHistory.php	2021-02-22 12:38:19 UTC (rev 10250)
@@ -30,13 +30,13 @@
 
  try this in a page called AuthorHistory:
 
-<?plugin AuthorHistory page=username includeminor=true ?>
+<<AuthorHistory page=username includeminor=true >>
 ----
-<?plugin AuthorHistory page=all ?>
+<<AuthorHistory page=all >>
 
  try this in a subpage of your UserName: (UserName/AuthorHistory)
 
-<?plugin AuthorHistory page=all includeminor=true ?>
+<<AuthorHistory page=all includeminor=true >>
 
 * Display a list of revision edits by one particular user, for the
 * current page, a specified page, or all pages.
@@ -49,13 +49,6 @@
 
 */
 
-/*
- reference
- _PageHistory_PageRevisionIter
- WikiDB_PageIterator(&$wikidb, &$pages
- WikiDB_PageRevisionIterator(&$wikidb, &$revisions)
-*/
-
 require_once 'lib/PageList.php';
 
 class WikiPlugin_AuthorHistory
@@ -96,6 +89,31 @@
     {
         $this->_args = $this->getArgs($argstr, $request);
         extract($this->_args);
+
+        if (($noheader == '0') || ($noheader == 'false')) {
+            $noheader = false;
+        } elseif (($noheader == '1') || ($noheader == 'true')) {
+            $noheader = true;
+        } else {
+            return $this->error(sprintf(_("Argument '%s' must be a boolean"), "noheader"));
+        }
+
+        if (($includeminor == '0') || ($includeminor == 'false')) {
+            $includeminor = false;
+        } elseif (($includeminor == '1') || ($includeminor == 'true')) {
+            $includeminor = true;
+        } else {
+            return $this->error(sprintf(_("Argument '%s' must be a boolean"), "includeminor"));
+        }
+
+        if (($includedeleted == '0') || ($includedeleted == 'false')) {
+            $includedeleted = false;
+        } elseif (($includedeleted == '1') || ($includedeleted == 'true')) {
+            $includedeleted = true;
+        } else {
+            return $this->error(sprintf(_("Argument '%s' must be a boolean"), "includedeleted"));
+        }
+
         if ($page && $page == 'username') //FIXME: use [username]!!!!!
             $page = $author;
         if (!$page || !$author) //user not signed in or no author specified

This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.