[phpwiki-checkins] SF.net SVN: phpwiki:[10160] trunk/lib/plugin/WikiAdminUtils.php

[<var...@us...>]

Revision: 10160
          http://sourceforge.net/p/phpwiki/code/10160
Author:   vargenau
Date:     2020-03-29 15:05:53 +0000 (Sun, 29 Mar 2020)
Log Message:
-----------
call_user_func passes arguments by value, so callees shouldn't expect by-reference parameter passing -- patches by Christof Meerwald

Modified Paths:
--------------
    trunk/lib/plugin/WikiAdminUtils.php

Modified: trunk/lib/plugin/WikiAdminUtils.php
===================================================================
--- trunk/lib/plugin/WikiAdminUtils.php	2020-03-23 13:08:19 UTC (rev 10159)
+++ trunk/lib/plugin/WikiAdminUtils.php	2020-03-29 15:05:53 UTC (rev 10160)
@@ -88,7 +88,7 @@
         return $this->_makeButton($request, $args, $label);
     }
 
-    protected function _makeButton(&$request, $args, $label)
+    protected function _makeButton($request, $args, $label)
     {
         $args['return_url'] = $request->getURLtoSelf();
         return HTML::form(array('action' => $request->getPostURL(),
@@ -100,7 +100,7 @@
             HiddenInputs($request->getArgs(), false, array('action')));
     }
 
-    function do_action(&$request, $args)
+    function do_action($request, $args)
     {
         $method = strtolower('_do_' . str_replace('-', '_', $args['action']));
         if (!method_exists($this, $method))
@@ -129,7 +129,7 @@
         return @$labels[$action];
     }
 
-    private function _do_purge_cache(&$request, $args)
+    private function _do_purge_cache($request, $args)
     {
         $dbi = $request->getDbh();
         $pages = $dbi->getAllPages('include_empty'); // Do we really want the empty ones too?
@@ -139,7 +139,7 @@
         return _("Markup cache purged!");
     }
 
-    private function _do_purge_bad_pagenames(&$request, $args)
+    private function _do_purge_bad_pagenames($request, $args)
     {
         // FIXME: this should be moved into WikiDB::normalize() or something...
         $dbi = $request->getDbh();
@@ -171,7 +171,7 @@
      * @param array $args
      * @return string|XmlContent
      */
-    private function _do_purge_empty_pages(&$request, $args)
+    private function _do_purge_empty_pages($request, $args)
     {
         $dbi = $request->getDbh();
         $count = 0;
@@ -206,7 +206,7 @@
                     : ''));
     }
 
-    private function _do_convert_cached_html(&$request, $args)
+    private function _do_convert_cached_html($request, $args)
     {
 
         require_once 'lib/upgrade.php';
@@ -223,7 +223,7 @@
         }
     }
 
-    private function _do_db_check(&$request, $args)
+    private function _do_db_check($request, $args)
     {
         longer_timeout(180);
         $dbh = $request->getDbh();
@@ -231,7 +231,7 @@
         return $dbh->_backend->check($args);
     }
 
-    private function _do_db_rebuild(&$request, $args)
+    private function _do_db_rebuild($request, $args)
     {
         longer_timeout(240);
         $dbh = $request->getDbh();
@@ -240,7 +240,7 @@
     }
 
     // pagelist with enable/disable button
-    private function _do_email_verification(&$request, &$args)
+    private function _do_email_verification($request, &$args)
     {
         $dbi = $request->getDbh();
         $pagelist = new PageList('pagename', array(), $args);

This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.