[phpwiki-checkins] SF.net SVN: phpwiki:[7098] trunk/themes/default/sortable.js

[<ru...@us...>]

Revision: 7098
          http://phpwiki.svn.sourceforge.net/phpwiki/?rev=7098&view=rev
Author:   rurban
Date:     2009-09-01 11:40:33 +0000 (Tue, 01 Sep 2009)

Log Message:
-----------
Declare locals
anonymous function does not always return a value

Modified Paths:
--------------
    trunk/themes/default/sortable.js

Modified: trunk/themes/default/sortable.js
===================================================================
--- trunk/themes/default/sortable.js	2009-09-01 11:38:52 UTC (rev 7097)
+++ trunk/themes/default/sortable.js	2009-09-01 11:40:33 UTC (rev 7098)
@@ -242,15 +242,15 @@
 	return compare_numeric(aa,bb);
 }
 function compare_numeric(a,b) {
-	var a = parseFloat(a);
-	a = (isNaN(a) ? 0 : a);
-	var b = parseFloat(b);
-	b = (isNaN(b) ? 0 : b);
-	return a - b;
+  var aa = parseFloat(a);
+  aa = (isNaN(aa) ? 0 : aa);
+  var bb = parseFloat(b);
+  bb = (isNaN(bb) ? 0 : bb);
+  return aa - bb;
 }
 function ts_sort_caseinsensitive(a,b) {
-	aa = ts_getInnerText(a.cells[SORT_COLUMN_INDEX]).toLowerCase();
-	bb = ts_getInnerText(b.cells[SORT_COLUMN_INDEX]).toLowerCase();
+	var aa = ts_getInnerText(a.cells[SORT_COLUMN_INDEX]).toLowerCase();
+	var bb = ts_getInnerText(b.cells[SORT_COLUMN_INDEX]).toLowerCase();
 	if (aa==bb) {
 		return 0;
 	}
@@ -260,8 +260,8 @@
 	return 1;
 }
 function ts_sort_default(a,b) {
-	aa = ts_getInnerText(a.cells[SORT_COLUMN_INDEX]);
-	bb = ts_getInnerText(b.cells[SORT_COLUMN_INDEX]);
+	var aa = ts_getInnerText(a.cells[SORT_COLUMN_INDEX]);
+	var bb = ts_getInnerText(b.cells[SORT_COLUMN_INDEX]);
 	if (aa==bb) {
 		return 0;
 	}
@@ -283,6 +283,7 @@
 		return r;
 	} else {
 		alert("Handler could not be removed");
+		return false;
 	}
 }
 function clean_num(str) {


This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.