[phpwiki-checkins] SF.net SVN: phpwiki:[7076] trunk/themes/wikilens/wikilens.js

[<ru...@us...>]

Revision: 7076
          http://phpwiki.svn.sourceforge.net/phpwiki/?rev=7076&view=rev
Author:   rurban
Date:     2009-08-24 12:12:46 +0000 (Mon, 24 Aug 2009)

Log Message:
-----------
Note required REST changes

Modified Paths:
--------------
    trunk/themes/wikilens/wikilens.js

Modified: trunk/themes/wikilens/wikilens.js
===================================================================
--- trunk/themes/wikilens/wikilens.js	2009-08-21 14:41:09 UTC (rev 7075)
+++ trunk/themes/wikilens/wikilens.js	2009-08-24 12:12:46 UTC (rev 7076)
@@ -120,6 +120,8 @@
   }
 }
 function submitRating(actionImg,page,version,dimension,newrating) {
+  //TODO: GET => PUT request
+  // currently ratings are changed with side-effect, but GET should be side-effect free.
   var myRand = Math.round(Math.random()*(1000000));
   var imgSrc = WikiURL(page) + 'version=' + version + '&action=' + rateit_action + '+&mode=add&rating=' + newrating + '&dimension=' + dimension + '&nocache=1&nopurge=1&rand=' + myRand;
   //alert('submitRating("'+actionImg+'", "'+page+'", '+version+', '+dimension+', '+newrating+') => '+imgSrc);
@@ -127,6 +129,8 @@
   document[actionImg].src = imgSrc;
 }
 function deleteRating(actionImg, page, dimension) {
+  //TODO: GET => DELETE request
+  // currently ratings are changed with side-effect, but GET should be side-effect free.
   var myRand = Math.round(Math.random()*(1000000));
   var imgSrc = WikiURL(page) + 'action=' + rateit_action + '&mode=delete&dimension=' + dimension + '&nocache=1&nopurge=1&rand=' + myRand;
   //alert('deleteRating("'+actionImg+'", "'+page+'", '+version+', '+dimension+')');


This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.