Re: [Phpwiki-talk] URL parameters not updated after saving a wiki

[Reini U. <ru...@x-...>]

Sabri LABBENE schrieb:
>  
> Sabri LABBENE wrote:
>> Reini Urban wrote:
>>> it's not easy.
>>> if so I would have done it years ago. (around 2003)
>>>
>>> you can search the archives how jeff tried to get rid of it, and/or i 
>>> introduced it again somehow.
>> Ok. Personally I tried to remove/unset it but I can't. 
>> Unfortunately this parameter causes problems for me... Anyway, 
>> I'll try to live with it until I'll get a solution to remove it.
> 
> In editpage.php (function savePage()) at line ~317 there is a :
>     //$request->setArg('action', false);
> When I uncommented that line, 'action=edit' parameter has gone but only
> once. I edit another time then save and the parameter stay there as before +
> a Notice:
> 
> In template 'head':51: Notice: Undefined index: action:
> 
>     * $action = $args['action'];

This is easy to fix :)

Ok, I just checked the logic.

Whenever you have the theme signature defined or a save warning,
the action=edit will be sticky, because then we do no redirect.

Without signature and no warning the request is redirected and the 
action=edit will be gone.

We need it to support more than one submit button.
We have Save, Preview and lateron maybe Changes and Upload.
For the later three we need "edit", unless we do some js tricks
to submit the form from the button, enabling edit only there. This is 
what we wanted to avoid.

But I'll test that idea.
-- 
Reini Urban
http://phpwiki.org/  http://murbreak.at/
http://helsinki.at/  http://spacemovie.mur.at/