Re: [Phpwiki-talk] Removed pages are not really deleted

[Reini U. <ru...@x-...>]

Manuel Vacelet schrieb:
> 2007/1/29, Stefan <son...@ba...>:
>> I've tried it with  _usecache = false and it works as it should.
>>
>> The solution could be to purge the cache before reading a deleted page.
>> or to disable the cache for the moment a deleted page should be read.
>>
>> To reset the cache on page deletion is not enough i think.
>> A page can be deleted with button "remove page" or removing the content
>> from the page.
>> Both have to reset the cache. But the second is first a normal edit
>> function.
>>
>> Maybe it's easier to do it while reading a deleted page.
> 
> Maybe it is (I didn't have a look at this) but from architecture point
> of view I think it's much more easy to do it on page deletion.
> - If user click on remove page, we have to purge the cache.
> - If user make the page blank (ie. remove contents) the cache will be
> automatically flushed.
> 
> I don't know what Reini thinks about these options (and if the patch
> do not break sth important).

I need some more time to test it.
Purging the memory DB_Cache AND the parsed cached_html in the db should 
fix that.

I also experience strange cache problems on MSIE in the meantime. Only 
on MSIE. This might be a ETags issue or some special browser cache logic.


>> Manuel Vacelet schrieb:
>> > 2007/1/26, Manuel Vacelet <man...@gm...>:
>> >
>> >> 2007/1/26, Stefan <son...@ba...>:
>> >>
>> >>> Hello Manuel,
>> >>>
>> >>> i have inserted the patch here but the result for me is the same as
>> >>> before (1.3.13 RC2)
>> >>> Entering a delteted page with the deleted page link in "recend 
>> changes"
>> >>> there is a message to create the page. open the page with the full
>> >>> linkname in browser url field (widthout action=create) the page is 
>> shown
>> >>> as before i deleted it. i will make the code tests to see when it 
>> stops.
>> >>>
>> >> Hello Stephan,
>> >>
>> >> I made the patch on a customized version of phpwiki 1.3.12p3 (on this
>> >> part, our customization shouldn't impact much).
>> >>
>> >> I remember I had to switch off HTML cache (USECACHE = false) during my
>> >> test but I can't figure if I re-enabled it after.
>> >>
>> >
>> > I didn't have time to test with the latest RC but I confirm I had to
>> > switch cache off and it didn't work with cache enabled.
>> >
>> > I think the good option it to reset html cache on page deletion.
>> >
>> > What do you think ?
>> >
>> > BTW, can you make the test with USECACHE = false ?
>> >
>> > -- Manuel
-- 
Reini Urban
http://phpwiki.org/  http://murbreak.at/
http://helsinki.at/  http://spacemovie.mur.at/