Re: [Phpwiki-talk] Removed pages are not really deleted

[Manuel V. <man...@gm...>]

2007/1/23, Reini Urban <ru...@x-...>:
> Manuel Vacelet schrieb:
> > 2007/1/20, Stefan <son...@ba...>:
> >> Hello Manuel,
> >>
> >> how do you access the page? If you access it with the link in recent
> >> changes (?) you are right.
> >> If you access the page with the url of the deleted page put it direct in
> >> the browser url field you will see the deleted page again.
> >
> > Unfortunatly I think it's not a cache issue (at least neither proxy
> > nor browser cache) because I tried to load page2 from a different
> > browser on a different machine.
> >
> > Moreover, I already set cache settings to NO_CACHE :/
>
> No, I meant our internal pagedb ache, not the browsers cache.

I found a solution.

In getPackedContent method, I added a test to verify if the requested
page is not deleted:
----------------------->8-----------------------
if (empty($data['%content'])
            || (!$this->_wikidb->isWikiPage($this->_pagename)
                && $this->isCurrent())) {
----------------------->8-----------------------

The remove a page will lead to following use case.
On page deletion:
- Page history add a mark about deletion.
- Links in other pages show the page as not existing.
- Direct access to the page give the same behaviour (Describe %s here).
- Page history show the previous states of the page.
- Access to an old revision of the page output the content of this old version.

Is my fix right ?