Re: [Phpwiki-talk] lib/DbSession/SQL.php:97: Notice: Only variables should be assigned by reference

[Joel U. <uck...@el...>]

Thus spake Reini Urban:
> $dbh =3D &$this->_connect();
> will be a problem on newer php's.
> 
> If it should be a reference, it should be declared in the function definiti=
> on,
> beforehand, and not later in the call.
> 
> Why it's there and why somewhere else I forgot? I'll think of it.
> dbh should be a ref and not a copy, esp. for ADODB which is quite heavy.

That's a good point. If the handle is some awful monstrosity, then we
don't want to copy it. Maybe it's the ones which *aren't* references which
are the bugs? It's never going to be slower to return a reference than
make a copy.

In that case, we should have _connect() returning a reference for all of the
DbSession backends, yes? If that accords with your intuition of how this
should be, I'll do it later today (really only a 30-second job).

-- 
J.