Re: [Phpwiki-talk] lib/DbSession/SQL.php:97: Notice: Only variables should be assigned by reference

[Reini U. <ru...@x-...>]

$dbh =3D &$this->_connect();
will be a problem on newer php's.

If it should be a reference, it should be declared in the function definiti=
on,
beforehand, and not later in the call.

Why it's there and why somewhere else I forgot? I'll think of it.
dbh should be a ref and not a copy, esp. for ADODB which is quite heavy.

2005/11/3, Stefan <son...@ba...>:
> >Line 97 looks like this:
> >
> >      $dbh =3D &$this->_connect();
> >
> >The reference is created by the ampersand. For the moment, it's unclear =
to
> >me what purpose the reference here is serving. Hence my question for Rei=
ni:
> >
> >
> >Reini: I noticed that in the DbSession code that the db handles are acqu=
ired
> >from _connect() using a mix of references and straight assignment (SQL.p=
hp
> >and ADODB.php use references only, dba.php uses assignment only, and PDO=
.php
> >uses a mix of the two). Is there a reason why these aren't uniform? I.e.=
,
> >do any of them actually need to be references? (I don't think so, but I
> >could be wrong.)