Re: [Phpwiki-talk] PATCH: local connection to pgsql

[strk <st...@ke...>]

On Tue, Oct 18, 2005 at 12:02:00PM +0200, Joel Uckelman wrote:
> Thus spake strk:
> > Hello, I've patched the lib/pgsql.php script
> > to allow for local (socket-based) connections.
> > 
> > Required change is at line 45 of that file:
> > 
> >       if ( defined($pg_dbhost) && $pg_dbhost != "" ) $connectstring = $pg_dbh
> > ost?"host=$pg_dbhost ":"";
> > 
> > This way you can set pg_dbhost to the empty string and the socket
> > will be used.
> 
> So this is against the 1.2 branch? I think that now we're only fixing
> bugs and security problems in the 1.2 branch.

Ehmm.. yes. 1.2.10.
I'd see it as a bug, BTW... the same check can be applied to
other parameters as well, an empty connect string is valid and
would use default paremeters (very useful for migrations).

> If you have a look at the config.ini for the current release (1.3.11p1),
> (you can see an example in CVS here: http://cvs.sourceforge.net/viewcvs.py/phpwiki/phpwiki/config/config-dist.ini?rev=1.59&view=markup), you'll see in Part
> Two how to connect to the database via a socket.

Urgh... a complete change in config files ? :(
Thanks for pointing out, anyway,
and thanks for making phpwiki available :)

--strk;