Re: [Phpwiki-talk] A gripe about SQL coding in phpWiki

[John S. <jst...@gm...>]

Hi Reini and All,


On 10/3/05, Reini Urban <rei...@gm...> wrote:
>
>
> I like rants. Thanks!


So do I, they usually provide useful information;)

>
> Interesting. Never heard of a system where setlocale("C") fails.
> Please post details to the phpwiki bug tracker. C is the mother of all
> locales.


I'll send this to the bugtracker later, but for now, here are the details o=
f
the error we see.
Fatal Error: lib/FileFinder.php (In template 'body' < 'htmldump'):191:
Error: locale/C/LC_MESSAGES/phpwiki.php: ????????????

Not exatly a helpful message. It is looking for the file
[wikihome]locale/C/LC_MESSAGES/phpwiki.php. Problem is there is no locale/C
or any subdirectories, either on my machine or in the 1.3.11p1 archive.

If you dig into the sources, you will see that those TRUE statements (also
> 1=3D1)
> come from the search library, which is a pretty good library IMHO.


I must disagree with this assessment. There should be no reason to do a TRU=
E
statement like 1 or 1=3D1 or NULL=3DNULL in any SQL. It is simply a way of
preformatting a WHERE clause so you can just keep tacking AND condition
statments to it, if there is a reason to. It is lazy programming. You shoul=
d
only create a WHERE clause if there are conditions that you need to limit a
query to. If you dont, then SELECT column1,column2 FROM tablex; is all you
need. Not SELECT column1,column2 FROM tablex WHERE 1=3D1; That is just lazy
programming.

We can easily set another SQL TRUE statement for this branch, and we
> haven't wrote a branch optimizer yet.
> Recommendations welcome.
> I'm just improving the postgresql interface, and oracle is not very far
> away.
> (foreign keys and text search improvements)


While I cannot work out where I can contribute to this, I am looking forwar=
d
to a much better Oracle implementation and will be keen to try it out.

You miss coding documentation? I cannot agree.


I am willing to be proven wrong ;) Can you point me in a direction to find
it? Thanks. Comments in the code are insufficient for someone not intimatel=
y
invovled in the development to get a rapid handle on how it all hangs
together.

I would agree that you miss updated user documentation for such features.


Is there are place I can find this also?

I'll look these up. Thanks for your patches.


Find them on the JohnStevens page. http://www.phpwiki.org/JohnStevens

For the future:
> Patches go to patches, bugs to bugs, feature enhancements to RFE.
> ("Requested Feature Enhancements")
> All at the sf.net <http://sf.net> projects page.


Thanks. Will remember that next time.;)

$ cd my-oracle-wiki
> $ patch -N -b -p1 < ../official-wiki.patch
> $ find -name \*.rej | xargs emacs
>
> looks not much of an overhead to me.
> I have about 5 different wiki's to sync, with various features to test,
> and it's very painless.


Painless if I haven't made a lot of changes to your source. I need to remak=
e
my changes by hand once I have your code patched or have an updated release=
.
If my changes are part of the release..........

Anyway, thanks for the response and guidance. Hope we can work on this
together. A great project that can be improved just a little. Any advice on
how to make the dump to XHTML exclude unwanted pages etc?

Regards