Re: [Phpwiki-talk] DevSync

[Reini U. <ru...@x-...>]

Thomas Harding schrieb:
> On Sun, Sep 25, 2005 at 05:07:10PM +0200, Reini Urban wrote:
> 
>>EditToolbars:
>>AddPlugins is currently broken (with my attached diff), but the new 
>>layout is fixed and better than before.
> 
> Works!
> Sorry for the huge : I edited files before to copy...

Great!
Just two points:
<br /> => \n is not that good. Templates actually force <br />.
It's just an artefact of $desc->asXML() expansion.

method_exists($this,'getArgumentsDesc') is not needed, because plugins 
should declare getArgumentsDescription() and not getArgumentsDesc() to 
override the default behaviour. Basic OO inheritance.

I'll commit that in the evening.
-- 
Reini Urban
http://phpwiki.org/