[Phpwiki-talk] [1.2.10] Re: another patch for phpwiki

[Reini U. <ru...@x-...>]

[please post to the list!]

> I have another enhancement I'd like to submit.
> Sometimes from my wiki I want to refer to plain html pages (non-wiki
> pages). But currently php wiki thinks references like this
> [/mywriteups/sql_notes.html]   are for a wiki page.

This is a feature.
/mywriteups/sql_notes.html is the name of a wikipage then.
external links require http:

> I have implemented and am currently using a fix for this.
> Should I post this idea and its patch in bugs / patches / or feature
> requests ?

no.

> Secondly,
> as I was modifying transform.php, my first step was to write some tester
> code that could regression test the existing features in transform.php
> before I added my new functionality.  This allowed me to make sure I
> wasn't breaking anything old as I put in the new feature.
> But I ran into an issue with the way transform.php is structured that
> got in the way of writing a good set of regression tests.

I don't think that we are interested in regression tests for 1.2.x
I only fix apparent bugs in the 1.2.x series, but nothing more.

> What I'm wondering is would you be interested in opening up some
> discussions on modifying the structure of the code to more easily allow
> testers to be written?   I would not want to just make a patch for this
> since it would be a set of small but fundamental changes.  Is there a
> way I can join the phpwiki development team so we could discuss?

Yes, post to the list instead. This is for the development team as well as
the users.

> A change like this would need to be discussed and understood by the
> development team beforehand and decide on when it could be merged into
> the head of tree depending on what other work developers were currently
> doing.

> -----Original Message-----
> From: Reini Urban [mailto:ru...@x-...]
> Sent: Tuesday, June 28, 2005 12:05 PM
> To: bik...@us...
> Cc: php...@li...
> Subject: Re: Patch to detect bad windows setup
>
>
> thanks for your work.
> please send it to me or to the list or file a bugreport st the sf.net
> page with the patch attached.
>
>> Message body follows:
>>
>>
>> After another evening reading the PHP manuals I've found the
>> problem.  If you follow the readme from php and use the
>> php.ini-recommended that comes in a windows php tar
>> distribution, then you get this nasty combination of settings
>>
>> register_globals = Off
>> register_long_arrays = Off
>> display_errors = Off
>>
>> What this does is that it thwarts the code in
>> phpwiki/lib/config.php AND does not put out an error.
>>
>>       if (!ini_get('register_globals') or
>> (ini_get('register_globals') == 'off')) {
>>           extract($HTTP_SERVER_VARS);
>>       }
>>
>>
>> with long arrarys off, and display errors off, that code
>> will fail, all the wiki links are bad, and you get no feedback.
>>
>> I have created a patch to address this.  The idea of the
>> patch would be to cut down on the amount of emails you
>> should have to address when people follow the mswindows
>> setups and end up with bad php.ini's.  This patch will
>> detect that condition and inform the user.
>>
>> I can't see in this sourceforge program how to attach my
>> patch so I'll look around on your project page.
>>
>> Joel


-- 
Reini Urban
http://phpwiki.org/   http://xarch.tu-graz.ac.at/home/rurban/