From: Reini U. <ru...@x-...> - 2005-02-07 12:40:17
|
Mikhail Vladimirov schrieb: > I have installed phpwiki-1.3.10 on my site, and I want to tell you, > what I think about it. > > I have tried to make Russian locale for it, to make my own theme, to > add some new special sequences (link --- for mdash, -- for ndash, (C) > for copyright sign e.t.c.). > > I found the following difficulties: > 1. [:alpha:], [:alnum:] and other character classes works well on my > PHP installation, while phpwiki still tries to use it's buggy > work-around for them. I want to be able to switch off that > work-around. We currently check in pcre_fix_posix_classes() for broken [:upper:] and use workarounds for [:alnum:], [:alpha:], [:upper:] and [:lower:] if the utf8 or Ä check fails. You say that your [:upper:] check fails, but [:alpha:], [:alnum:] do work ok? I cannot believe this. Maybe you can find out why your utf8 or Ä check fails. preg_match('/[[:upper:]]/', 'Ä')) => true preg_match('/[[:upper:]]/', '\xc4\x80') => true > 2. 'strict' authorization scheme is broken (it tries next > authentication method if previous method says, that user exists, but > password is wrong). I have fixed this bug by deleting several lines > in WikiUserNew.php (first 'if' statement in function _tryNextPass of > class PassUser) Thanks! > 3. WIKI_NAME_REGEXP is used for both automatic link creation and for > checks for valid user names. I prefer to apply to user names weaker > conditions, then to automatic links. I want to be able to specify two > different regular expressions for this two cases. Sure. Username checks must be class methods, because the strictness is backend specific. auth, pref and db backend specific. bogousers are WIKI_NAME_REGEXP specific. pageprefs users must use pagename validity checks, based on the db backend. (valid filenames) We shoudl work around this filename limitation by using urlencode in the file backend storage mechanism. But not for 1.3.11 yet. SQL pref and auth users must use SQL-specific validity checks. LDAP auth usernames are even stricter, because it easier to fool ldap than properly quoted sql. > I am an expierenced PHP programmer and I think, I can help with > development of phpwiki. At least I can submit Russian locale for it. > My user name at sourceforge is mvladimirov. Great! I always loved to work with russian programmers back in old Autolisp days. What is quite difficult and for which I have no time yet, is adding support for Markup_isonumchars in lib/InlineParser.php TODO: "..." => "…" browser specific display (not cached?) TODO: "--" => "&emdash;" browser specific display (not cached?) You want this, I believe. Currently any & is converted to & so we should escape it somehow (functional style) or use an OO approach as in HTML::Raw. -- Reini Urban http://phpwiki.org/ |