[Phpwiki-talk] french cancan ... the locale dance in phpwiki :)

[Arnaud F. <ar...@cr...>]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hi all,

A friend and I are investigating the locale problem ...

I found a few cleaning to do in the code and found some strange stuff.

First, the cleaning :

Index: lib/main.php
===================================================================
RCS file: /cvsroot/phpwiki/phpwiki/lib/main.php,v
retrieving revision 1.205
diff -r1.205 main.php
809c809
<         if (0 and $GLOBALS['LANG'] != 'en') {
- ---
|         if ($GLOBALS['LANG'] != 'en') {
1764c1764
< ?>
\ No newline at end of file
- ---
| ?>


(what did you want to do there ?)

Index: lib/WikiUserNew.php
===================================================================
RCS file: /cvsroot/phpwiki/phpwiki/lib/WikiUserNew.php,v
retrieving revision 1.124
diff -r1.124 WikiUserNew.php
1461c1461
<         if ($value == '' or empty($value))
- ---
|         if (empty($value))
2379c2379
< ?>
\ No newline at end of file
- ---
| ?>

empty($value) is equivalent to (!isset($value) or $value == NULL)

Index: navbar.tmpl
===================================================================
RCS file: /cvsroot/phpwiki/phpwiki/themes/default/templates/navbar.tmpl,v
retrieving revision 1.35
diff -r1.35 navbar.tmpl
3c3
<
- ---
| if(!$page->getName()) {
59c59,61
< } ?>
- ---
| }
| }
| ?>

I already sent this one ...

And now, the funny stuff ...

I forced the locale to fr in IniConfig.php because it was switching from
fr_FR to C ...

Index: lib/IniConfig.php
===================================================================
RCS file: /cvsroot/phpwiki/phpwiki/lib/IniConfig.php,v
retrieving revision 1.77
diff -r1.77 IniConfig.php
591a592
|     $LANG = 'fr';
625a627
|       setlocale(LC_MESSAGES, 'fr_FR');
1107c1109
< ?>
\ No newline at end of file
- ---
| ?>


setting the locale there (setlocale) corrected the problem ...

Hmmm .... Reini ?? Any idea ??

Arnaud
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.5 (GNU/Linux)
Comment: Using GnuPG with Thunderbird - http://enigmail.mozdev.org

iD8DBQFCAjb1yAf3wgFyy1ARAmklAJ99KHSP6I/5W+qvCDt60Mue5ffFEgCglsvW
MORKYz4uojLJVwsB9xxERkM=
=aMEQ
-----END PGP SIGNATURE-----