Re: [Phpwiki-talk] WikiDB.php caching fix part 2 of 2

[Reini U. <ru...@x-...>]

Charles Corrigan schrieb:
>>Charles Corrigan schrieb:
>>>A patch to lib/WikiDB.php follows.  This is part 2 of my previous set of fixes to the
>>>caching logic. 
>>>
>>>While debugging why caching was not working for me, I found that get_versiondata()
>>>was behaving weirdly when the parameter $need_content was false.  It appears that
>>>php 4.3.10 on windows gets confused when an array element is created with an index
>>>of '0'.
> 
>>Please try to update your zend optimizer first.
>>  https://www.zend.com/store/products/zend-optimizer.php
>>I had the same problem.
> 
> I have never downloaded or used the zend optimizer on my windows machine, this is a stock php 4.3.10 on windows.  Therefore I
> suggest that the change is made as it will affect others that know nothing of the zend optimizer.  The patch is merely a change to
> otherwise unused constants, not a change to logic.

Ok, I will apply this patch, because it's simple and the index ['0'], 
has some ill magic. (empty, isset, ...)

But the point is still:
If your php is broken you have to fix the real problem,
because this special case in WikiDB_Cache will not be the only problem then.

-- 
Reini Urban
http://xarch.tu-graz.ac.at/home/rurban/