Re: [Phpwiki-talk] SQL syntax fix in lib/WikiDB/backend/PearDB.php

[Reini U. <ru...@x-...>]

Charles Corrigan schrieb:
> in WikiDB_backend_PearDB->exists_link() - lines 579 - 581 should be
>                                 . " AND $have.pagename='$qpagename'"
>                                 . " AND $want.pagename='$qlink'"
>                                 . " LIMIT 1");

Aah, thanks. A escape-change left-over. Hopefully the last.

BTW: This is one of the major WikiDB-pear changes from 1.3.10 to 1.3.11. 
I have to document that mor prominently in the ReleaseNotes, that 1.3.11 
requires now a quite new pear DB module. To finally have uniform quoting 
style.

We didn't yet change to the ADODB-style to automatically support all 
databases, but it's on its way. Our pear db backend still requires an 
explicit PearDB_<backend>.php file.

> While tracking this problem, I noticed that the LIMIT clause was commented
> out in most places - is it applicable here?

GetRow needs it explicitly. In most other cases I changed ->query() to 
use ->LimitQuery() instead.
This is just for cross-db compatibility.
E.g. certain SQL operations disallow the "LIMIT from, count" syntax.

-- 
Reini Urban
http://xarch.tu-graz.ac.at/home/rurban/