Re: [Phpwiki-talk] double underscores munged in URLs

[Joel U. <uck...@no...>]

Thus spake Reini Urban:
> Joel Uckelman schrieb:
> > I think I have a solution for bug 1090579, https://sourceforge.net/tracker/
> i
> > ndex.php?func=detail&aid=1090579&group_id=6121&atid=106121. I'd appreciate 
> > it if someone more familiar with the markup parsing code than I am would 
> > take a look at my suggested fix and tell me if it seems sane before I 
> > commit it and close the bug.
> 
> Your "__" patch to prevent from bold detection. This is indeed hairy code.
> Shouldn't this also be done for italic?

The reason I decided not to do this for italics is that single quotes 
shouldn't be in the URL to begin with, so trying to make a link containing 
them *should* fail, right?

> Better would be to urlencode/decode those magic tags in pagenames/urls:
>    "__", "''"

urlencode() won't encode underscores, because they're legal characters in 
URLs.
Also, if you do it that way when you have a link with no accompanying text 
it doesn't render properly. The link is displayed containing '%5F%5F' 
instead of '__'.

-- 
J.