Re: [Phpwiki-talk] Plugins Executed Twice, Displayed Only Once?

[Rui C. <rui...@ac...>]

Bingo. I spotted it late yesterday evening when trying to figure out  
what PageType was for. My fork already had some of those lines moved  
around (I added If-Modified-Since checking near those bits and return  
"not modified"), but that was basically it.

Which would definitely place my fork as  
1.3.7-plus-bits-of-other-versions-on-steroids :)

If only it wasn't running for two years like this (sigh). Well, at  
least my other optimizations work even faster now :)

R.

On Dec 7, 2004, at 1:33, Carsten Klapp wrote:

>
> On Dec 6, 2004, at 6:28 am, Rui Carmo wrote:
>
>> Hello there.
>>
>> I'm running a heavily customized version of PhpWiki at  
>> http://the.taoofmac.com, and have come up with an interesting  
>> problem.
>>
>> It might be from my tweaks (I forked my code from PhpWiki sometime  
>> around 1.3.7, I think), but plugins in the node contents seem to be  
>> invoked twice, i.e:
>>
>> * if I use PageTrails as part of browse.tmpl, it is only invoked once
>> * If I add <?plugin PageTrails ?> to my Sandbox, the plugin code  
>> (i.e., run()) gets invoked twice, even though the output is only  
>> shown once.
>
> Hi Rui,
>
> This sounds exactly like the "double transformation" bug which I  
> (inadvertently introduced, and later) fixed around 1.3.7.
>
> I think you may find the answer here, by comparing an old revision of  
> PageType.php with the one before it:
>
> http://cvs.sourceforge.net/viewcvs.py/phpwiki/phpwiki/lib/ 
> PageType.php?r1=1.9&r2=1.10
>
> IIRC normally you wouldn't notice the double transformation, except on  
> pages which contain plugins, so I'm quite sure this is it.
>
> I haven't had time to work on PhpWiki in almost a year but I do  
> periodically monitor this list and thought I could help in this case.  
> If this does not turn out to be the cause of the problem, I'm sorry  
> then, offhand I don't know what else to try as I am quite out of date  
> with the current code.
>
> Carsten