From: Charles C. <ch...@ru...> - 2004-12-04 13:30:33
|
On Thu, December 2, 2004 10:38, Reini Urban said: > Charles Corrigan schrieb: > > Just to clarify, I had problems with page ownership since I started > > playing with 1.3.11pre - my previous patches were chipping away at bits > > of the problem. > > oh. Sounded like the cache problem I was working at. > > > What I am testing is from CVS as on Saturday - I will upgrade > > to latest over the weekend. > You have been warned. The pagedata and versiondata cache revamp is not > finished, it's dirty, and I want to clean it up without using too much > memory. With a clean install, the steps to reproduce this problem are: 1 - change the owner of the page PageGroupTest/Four from CarstenKlapp to another user 2 - view the page - will correctly show the new owner 3 - view PhpWikiAdministration/Chown - it will still show Carsten as the owner. I have traced this problem through the call stack to WikiDB_Page->getOwner() and WikiDB_Page->get() - get() does not find a value for 'owner' in the metadata of the page and it falls back to 'author_id', staring from the first available version of the page. As Reini suggested, it does appear that this is related to caching - when the page is actually being displayed, all of the data is correct. However, when the page is referred to indirectly (via lib/plugin/WikiAdminChown.php, lib/plugin/WikiAdminSelect.php and lib/PageList.php in this case), the cached data is incorrect or incomplete. So far, I have been working around the periphery. I do not really know how all of this works, so it may take me a while before I find anything. Given that Reini are working on the caching, is it worth me investigating further? Regards Charles |