Re: [Phpwiki-talk] [RFC] AppendTextPlugin

[Reini U. <ru...@x-...>]

Pascal Giard (QC/EMC) schrieb:
> Here's a first working version.
> Comments are very welcome.

Great. Was it easy?

Some comments: A pagehandle is really a handle (ptr to a WikiDB_Page 
object). You should name it pagename.
"lbound" and "hbound" are strange argument names, but they are yours, 
and we don't have similar args yet.
I personally would rather name those "before" and "after". A bound is 
normally numeric.
Shouldn't there be some fallback in case of hbound/lbound replace will 
not succeed? Either an error message or add to end. It also should be 
preg_quote'd, since it's a user arg.

Question is: Do we want that included into the PhpWiki distro?
I think so.
We initially thought that AddComment should be enough, and easier to 
seperate from the existing content. But this argument is bogus.

> -Pascal
> PS: rename .zipped to .zip ... sorry, had to do that because of 
> Ericsson's mail scanner.

I'll add this at the sf.net site under RFE, after some cosmetic changes.
   http://sourceforge.net/projects/phpwiki/
People tend to prefer webbrowsing than email archive scanning.
-- 
Reini Urban
http://xarch.tu-graz.ac.at/home/rurban/