Re: [Phpwiki-talk] yet another strange problem with themes

[Reini U. <ru...@x-...>]

Arnaud Fontaine schrieb:
> I was migrating a 1.3.4/gdbm running wiki using my own theme to a cvs
> export version with MySQL as a backend.

gdbm locking problems also? those php guys should be beaten!

> I finally managed to import all versions of the pages ! How ? Just
> increasing the upload max size in the config.ini and adding 'override =
> 1' in the hidden action array in the WikiForm plugin ...

local import would have been much faster. just give source=... to 
action=loadfile. anyway.
upload is not very good.

> Well ... this was the first step ...
> 
> Then, I wanted to look if my 1.3.4 homebrew theme (the igenerator.net
> theme ... don't go look at it, you'll understand why reading a few more
> lines) was still working in the current CVS, what adjustemets I had too
> do, etc. 
> 
> Oh, btw, as I run a wikifarm, with each wiki on it's own host name, I
> run it outside the phpwiki directory and made the corresponding
> modifications to index.php and to my config.ini ...
> 
> I linked the various themes inside the local 'themes' directory (I also
> tried copying them there ...) and, with the exception of the Crao theme
> working just fine this way, I always have the default theme displaying.

> I already noted on previous versions that phpwiki always looks to the
> themes files inside the phpwiki installation directory (that's why I
> link and do not copy) ... and don't tell me it's a feature ... 

where do you want it? we don't want to support local themes dirs.
it is not necessary, even not for big farms.

or do you really want for every wikifarm'ed wiki a different theme with 
the same name? same names are forbidden.
if so, I would copy Crao for every locally wanted and extendable theme 
within the themes dir.  just give them a useful name.
can even be autogenerated from the domain or username. (adjust it in the 
theme loader)
and if you want the wiki admins give access to their theme, just symlink 
it to their homedir and give them the file perms.

> I also noted that the UserPreferences looks to the list of themes in this
> directory and not in the local themes directory ...

For the themes loader see below:
So either PHPWIKI_DIR is empty or wrong. NormalizeLocalFileName is in 
FileFinder.php, and adds PHPWIKI_DIR if defined.

function Theme ($theme_name = 'default') {
   $this->_name = $theme_name;
   $this->_themes_dir = NormalizeLocalFileName("themes");
   $this->_path  = defined('PHPWIKI_DIR') ? NormalizeLocalFileName("") : "";
   $this->_theme = "themes/$theme_name";

   if ($theme_name != 'default')
      $this->_default_theme = new Theme;
      $this->_css = array();
}

-- 
Reini Urban
http://xarch.tu-graz.ac.at/home/rurban/