Re: [Phpwiki-talk] Updates with WikiLens code ?

[Dan F. <dfr...@cs...>]

Reini,

As usual, you are much faster than I am! Thanks for your efforts.

Three things:

1. We are _about_ to release another round of changes. We are on RC5, 
and hope to be out early next week. Thus, there are some changes that 
you haven't seen yet.

2. You say there are a lot of style and other issues to fix in our code. 
I agree. However, if you go through and make small changes everywhere, 
it becomes difficult for us to merge. I'm not quite sure what to do 
about this. Unfortunately, I'm not sure if it's feasible to give you 
access to our CVS directly; you'd have to have a University account, and 
I'm not sure if that's possible. I'm thinking. Also, some prior changes 
you made actually broke rating functions we used, since there were no 
unit tests for them. I'm also thinking about that. I have to go now, but 
I will seek ideas. Basically, we'd have to look over your changes and 
try to integrate them, or something like that. Not sure, but it would be 
more than a day for us.

3. I fully intend to respond to your comments on our Wiki, but it may 
take me a few days. Thanks again for your patience.

Dan

Reini Urban wrote:

> Reini Urban schrieb:
>
>> Dan Frankowski schrieb:
>>
>>> WikiLens has been drifting farther and farther from PhpWiki code. 
>>> However, I'd love to contribute the code back into PhpWiki! There 
>>> are several issues, tho. I'd appreciate your advice.
>>
>>
>> I started now cleaning up the current wikilens code.
>> But there are a lot of style and other issues I need to fix.
>> Featurewise we will come together somehow.
>>
>> Should I put my changed versions into the PhpWiki site or PhpWikiDemo 
>> or WikiLens? So that we can discuss it, together with the original 
>> author.
>> Some plugins are really terrible written. :)
>>
>> Maybe diff's are enough.
>> I would suggest PhpWiki:WikiLensDevelopment/Filename, but the sf.net 
>> server is so slow, that I would prefer your server.
>
>
> I posted the current status of affairs there:
>
>   http://www.wikilens.org/wiki.php/ReiniUrban/WikiLensPatches
>
> There's some work to be done, but nothing problematic.
> one day work probably.