Re: [Phpwiki-talk] broken php5 update ?

[Reini U. <ru...@x-...>]

It worked under php5 pre-releases, but they deciced to
fatal at "var" versus "public/private/protected".
Turning off the E_STRICT error bit would be enough.
Could you find out the numeric value of E_STRICT and where to add it?

There's a wiki page:
http://phpwiki.sourceforge.net/phpwiki/Php5Testing

Right now I'm stuck with postgres/apache/php debugging problems (I took 
over cygwin maintainership), so I don't have enough time.
I really want to find the annoying memory exhaustion problem first.

The pcre crash with ConvertOldMarkup is not fixed by the 4.3.9RC2 
update, but I worked around by defaulting loadsave to markup=2, which 
should work for most cases.


Jerome WAGNER schrieb:
> I'm trying to make phpwiki work out of CVS under php5 (I thought earlier
> migration issues had been resolved)
> 
> the first problems I hit include:
> 
> 1/ use of "static" functions not declared as static
> 
> lib\XmlElement.php:519: Fatal[2048]: Non-static method XmlContent::_quote()
> should not be called statically

this is new to me. wonder why.

> 
> 2/ "var" versus "public/private/protected"
> 
> lib\FileFinder.php:18: Fatal[2048]: var: Deprecated. Please use the
> public/private/protected modifiers
> 
> 
> is this normal ? should I specify some special ini directives in order for
> it to work ?
> 
> I tried
> ini_set('zend.ze1_compatibility_mode', '1');
> but it did not work any better.
> 
> I am very interested in a working version of phpwiki under php5 and could
> spare some time on it (I am trying to work only on php5 projects from now
> on).
> 
> I know that you have already spent some time on the compatibility Reini and
> have a few questions :
> - what are the main remaining issues ?

E_STRICT

> - it seems hard to keep a dual version because of new language constructs.
> should there be a 1.4 or 1.5 phpwiki branch dedicated to php5 or should
> there be a generic patcher (like the php5_patch.php that used to exist ?)

the patcher is not needed anymore. I worked around with eval.

> - are there any architectural issue in the code that would need major
> rewrites in order to port php4 to php5 ?

no.
-- 
Reini Urban
http://xarch.tu-graz.ac.at/home/rurban/