From: Matthew P. <mp...@he...> - 2004-06-28 23:51:16
|
On Tue, Jun 29, 2004 at 09:14:42AM +1200, Jim Cheetham wrote: [__CONFIGURED for multiple Wikis] > I'd like to see this too, because I'm currently running three wikis on > the same machine, with the associated duplication of code files. Perhaps > Matthew could implement this, and Reini could accept it into CVS? Reini said he didn't like my idea, and preferred his way of doing it. See http://sourceforge.net/mailarchive/message.php?msg_id=8500690. The problem I see with Reini's idea is that it relies on trusting IniConfig not to go overwriting existing define()s. That's fine and dandy now, but without giant "Here be Monsters, lad" all over the IniConfig code, someone in the future is going to change it to do just that (because constant leakage is bad), and suddenly all of your custom Wikis die. Also, you're splitting the config into multiple parts again -- one for defines, and one for variables. With the number of variables in PHPWiki (and the fact that now, with IniConfig, they're no longer documented as being variables in the config file, but only in the depths of IniConfig() -- and that's subject to change without notice), you're going to have a hard time figuring out which one's which. My system adds little in the way of complexity -- both methods require .htaccess fiddling and snippets of custom code, as does mine -- but mine allows you to use the same config method for custom sites -- an IniConfig file -- as the main site. But hey, to each their own. Reini thinks my idea sucks, I think his does, and we all clap hands together. He runs the project, and does it well enough that I doubt anyone's about to start muttering about mutiny or taking their bat and ball because of a different method of doing multi-wiki. I'll run up a patch if anyone is truly interested (and I'll even keep it current against future releases), but it's such a simple modification that you can do it yourself at home with simple hand tools -- as documented in my original E-mail (for reference, http://sourceforge.net/mailarchive/message.php?msg_id=7966839). - Matt |