Re: [Phpwiki-talk] cvs access to dfrankow

[Dan F. <dfr...@cs...>]

Reini Urban wrote:

> Dan Frankowski schrieb:
>
>> I am trying to update the unit tests to the package I sent you (make 
>> it more picky, add some tests). I tried to add a directory, and do 
>> not seem to have permissions:
>>
>> ../phpwiki-next/tests/unit) % cvs add testbox
>> ? testbox/latest_ver
>> ? testbox/links
>> ? testbox/page_data
>> ? testbox/ver_data
>> cvs [server aborted]: "add" requires write access to the repository
>> ../phpwiki-next/tests/unit) % cat CVS/Root
>> :pserver:dfr...@cv...:/cvsroot/phpwiki
>>
>> Can you give me write access?
>>
>> Perhaps this could be because I am a project member, but as 
>> "Advisor/Mentor/Consultant" and not "Developer". Maybe change me to 
>> "Developer"?
>
>
> strange. done.


Thanks. I have not yet tested it, since you are uncertain about the 
directory. More below.

> But why would you like to add the textbox?
> Don't you have the latest test.php?
> I renamed it to .testbox, so that it wouldn't display in cvs.


I have the latest test.php in Sourceforge's repository. However, I also 
have a bunch of changes that I emailed to this list as a tarball and you 
haven't had time to apply. I thought I'd apply them.

One of the changes is to add an error handler (instead of just an assert 
handler). This is useful because then if there is incorrect PHP syntax, 
vars missing, etc., the tests don't run. In other words, the tests get 
more picky, which is good. When they get more picky, they want an 
existing testbox with some stuff in it (InterWikiMap, global_data, a few 
other things). Thus, I want to make a "testbox" in CVS with the right 
stuff and check it in, as I did on our local copy.

Since I do not wish to make changes that you don't want, please tell me 
that you approve. Then I'll go ahead and make the unit test changes, 
including adding a CVS-tracked "testbox" with stuff in it.

Dan