[Phpwiki-talk] allow_call_time_pass_reference clean

[Reini U. <ru...@x-...>]

Reini Urban schrieb:
> John Cole schrieb:
>> Reini,
>>   I tried to authenticate and I crashed again, so I just deleted my 
>> dev copy and pulled a new one from CVS.
> 
> BTW: All these errors come from allow_call_time_pass_reference = Off in 
> php.ini. allow_call_time_pass_reference = On is a required php setting 
> for some time now, until we fixed it and php5 is there. But even php5 
> allows to set it on.
> 
> I haven't tested against allow_call_time_pass_reference = Off yet, but 
> now that I'm aware of this problem with newer php's, I can reproduce it 
> easily and I am on the way to fix it in all places. There are a lot!
> 
> The real problem is that all these changes have to be tested with older 
> php versions. This will need some time.
> 
> Any reasonable ISP server with php has this On, otherwise 70% of all 
> existing scripts will bark.

I commited now the fixes for allow_call_time_pass_reference = Off in 
php.ini to CVS.

Most problematic pages which require references, and all dumps worked 
fine so far.
I still have to test older php's and php5.

PhpWiki is now allow_call_time_pass_reference = Off clean,
but several external libraries may not.
In detail these libs look to be affected (not tested):
   * Pear_DB odbc
   * adodb oracle

>> [15-Jun-2004 09:18:46] PHP Warning:  Call-time pass-by-reference has been
>> deprecated - argument passed by value;  If you would like to pass it by
>> reference, modify the declaration of [runtime function name]().  If you
>> would like to enable call-time pass-by-reference, you can set
>> allow_call_time_pass_reference to true in your INI file.  However, future
>> versions may not support this any longer.  in C:\Program Files\Apache
>> Group\Apache2\htdocs\phpwiki\lib\plugin\CreateToc.php on line 226
...
-- 
Reini Urban
http://xarch.tu-graz.ac.at/home/rurban/