RE: [Phpwiki-talk] Re: Line breaks in new markup - SOLUTION

[Paul B. <pa...@pa...>]

> Without those linebreaks the text in the textarea is more difficult to
real 
> (IMHO) and more importantly: it also makes the diffs more difficult to
read 
> because a one letter change in a huge paragraph (consisting of only a
single 
> long line) makes you compare the old long line with the new long line.
I 
> know how the changes within a line are highlighted, but I still don't
want
> to see the rest of the huge line in the diff.

You have a good point Martin, particularly re. diffs - however for my
purposes that issue is secondary to the natural flow for users.

Anyway, if anyone else wants line breaks in their HTML paragraphs where
they appear in their wiki text, the following mod should achieve it:

FILE     lib/BlockParser.php
CLASS    Block_p
FUNCTION finish
REPLACE  $content = TransformInline(trim($this->_text));
WITH     $content = TransformInline(str_replace("\n", '<br>',
trim($this->_text)));

IMHO It would be good to get this in the CVS, controlled by a flag in
index.php.

Paul


-----Original Message-----
From: Martin Geisler [mailto:gim...@gi...] 
Sent: 25 February 2004 13:00
To: php...@li...
Subject: [Phpwiki-talk] Re: Line breaks in new markup


"Paul Bloomfield" <pa...@pa...> writes:

>> why not use <br> for intentional linebreaks?
>
> The answer to that question, at least, is easy! It just isn't wiki. 
> The first thing people like about a wiki is that what you type in the 
> edit box appears on the web page, you don't need to use <p> or <br /> 
> tags.  If you type a new line in the edit box, you want a new line on 
> the web page, otherwise you wouldn't have typed it!

No, I always break my lines at around 60-70 characters when I edit my
wiki pages, just like I do when I edit code, emails or any other ASCII
text document.

Without those linebreaks the text in the textarea is more difficult to
real (IMHO) and more importantly: it also makes the diffs more difficult
to read because a one letter change in a huge paragraph (consisting of
only a single long line) makes you compare the old long line with the
new long line.  I know how the changes within a line are highlighted,
but I still don't want to see the rest of the huge line in the diff.

-- 
Martin Geisler                       My GnuPG Key: 0xF7F6B57B

See http://gimpster.com/ and http://phpweather.net/ for:
PHP Weather:   Shows the current weather on your webpage and
PHP Shell:     A telnet-connection (almost :-) in a PHP page.


-------------------------------------------------------
SF.Net is sponsored by: Speed Start Your Linux Apps Now.
Build and deploy apps & Web services for Linux with
a free DVD software kit from IBM. Click Now!
http://ads.osdn.com/?ad_id=1356&alloc_id=3438&op=click
_______________________________________________
Phpwiki-talk mailing list
Php...@li...
https://lists.sourceforge.net/lists/listinfo/phpwiki-talk