Re: [Phpwiki-talk] Greetings: pnPhpWiki

[Reini U. <ru...@x-...>]

electron schrieb:
> Reini Urban schrieb:
>>haven't I fixed this adodb limit bug recently in CVS?
>>anyway I added it, since it makes sense.
> 
> I didn't add it since it makes no sense. my adodb fix from last months 
> fixed the limit problem.
--
I fixed it in WikiDB/backend/ADODB.php:600
Id: ADODB.php,v 1.13 2004/02/12 14:11:35 rurban Exp

> I still get it inside pnPhpWiki. I'm on Version 1.12 of adodb.php. Error
> still pops up using either ADODB backend or pnADODB backend (custom backend
> that uses postnuke calls to adodb)

bad, bad, since I cannot reproduce it now. Jeff wanted the RecentChanges 
feature to not enable a limit per default. cannot you fix it elsewhere? 
in the adodb backend?

> I made an alpha release at http://noc.postnuke.com/projects/pnphpwiki/ which
> will reproduce the behavior if the patch isn't used.

ok, I'l try this.

> Divergent path:
> In playing with pnPhpWiki, PageHistory caused some intresting behavior with
> the way it uses urls.
> 
> Proposal: in stdlib, a useForm() or WikiForm() function be created that acts
> as a wrapper to HTML::<form>? I suggest this because of the need that all
> pages when phpwiki is run as a module need additional arguments (op,
> modload, etc) and when HTML::form is called in PageHistory, those postnuke
> required args should be hidden input elements, but are not.

a wrapper just for every form is hard. cannot you add a helper call to 
every POST form?

> The dirty solution is to hack PageHistory.php, the clean one is to
> encapsulate.
> 
> Also: in stdlib, a getDefaultArg() function that is called by WikiUrl() and
> proposed WikiForm()
> In standard phpwiki, this would return nothing, hackers like myself can dump
> my postnuke vars in there and have it work sitewide.

looks okay to me, since I need zend studio start_debug=1 also in all GET 
calls and for POST forms as hidden inputs.
but I think I already added such a url helper to stdlib. just cannot 
find it yet.
-- 
Reini Urban
http://xarch.tu-graz.ac.at/home/rurban/