From: Steven L. <st...@tu...> - 2003-03-14 20:15:36
|
Hello All, I was sifting through the core today and found a few functions that are no longer being used. Array.php: shove shoveAssoc XML_it cmp Text.php: error_list If no one has any objection I would like to remove these functions just for general clean-up purposes. (Trying to reduce memory limit) Also there are functions which are only being used by one module. Array.php: swap (phatform) reindex (phatform) maxKey (layout) objectToArray (calendar) Database.php: sqlFriendlyName (phatform) sqlImport (setup/boost specific) - I figure sqlImport and all the helper functions can be included with boost and setup (when they run) Form.php: clock (calendar) alphabet (users) WizardBag.php: whereami (comments) For these functions we should vote on whether they stay in the core, or be moved to the module where they are used. Thanks! -- Steven Levin Electronic Student Services Appalachian State University Phone: 828.262.2431 PhpWebsite Development Team URL: http://phpwebsite.appstate.edu Email: st...@NO... |
From: <ad...@tu...> - 2003-03-14 20:30:02
|
> Array.php: shove > shoveAssoc > XML_it > cmp > > Text.php: error_list > > If no one has any objection I would like to remove these functions just > for general clean-up purposes. (Trying to reduce memory limit) +1 to killing all of those. > Also there are functions which are only being used by one module. > > Array.php: swap (phatform) KEEP > Array.php: reindex (phatform) KEEP > Array.php: maxKey (layout) MOVE > Array.php: objectToArray (calendar) MOVE > Database.php: sqlFriendlyName (phatform) KEEP > Database.php: sqlImport (setup/boost specific) KEEP > Database.php: clock (calendar) MOVE > Database.php: alphabet (users) MOVE > WizardBag.php: whereami (comments) MOVE -- Adam Morton Developer - Electronic Student Services http://phpwebsite.appstate.edu Founder - Appalachian Linux Users Group http://alug.appstate.edu |
From: Matthew M. <ma...@tu...> - 2003-03-14 20:46:34
|
For my modules: If any functions are only used once, you can just dump at the bottom of the file that uses it and remove the core-> from the front. Alert me when done and I'll clean up. Matt |
From: Eloi G. <el...@re...> - 2003-03-16 14:24:42
|
Steven, >Array.php: shove > shoveAssoc > -1. Just because we're not using it now doesn't mean that some future module developer won't require it. > XML_it > cmp >Text.php: error_list > > +1 for removal. These functions are either too simple or would most likely require modification to suit personal preferences before use. >Also there are functions which are only being used by one module. > >Array.php: swap (phatform) > reindex (phatform) > maxKey (layout) > objectToArray (calendar) > >Database.php: sqlFriendlyName (phatform) > sqlImport (setup/boost specific) > - I figure sqlImport and all the helper functions can be > included with boost and setup (when they run) > >Form.php: clock (calendar) > alphabet (users) > >WizardBag.php: whereami (comments) > > -1. Keep these in place. Like I said before, we don't know who else might need them. In this case, I'm actually using reindex() and MaxKey() in one of my module development projects. If we're really worried about memory usage, we should decide what we're going to do about PHPWS_Form vs. EZform. Eloi George |
From: Steven L. <st...@tu...> - 2003-03-17 14:39:45
|
> Steven, > >>Array.php: shove >> shoveAssoc From what I here from the other developers here, these two functions do not even work properly. Sorry they are going to be removed. > >> XML_it >> cmp >>Text.php: error_list >> >> Going, going, gone. >>Also there are functions which are only being used by one module. >> >>Array.php: swap (phatform) >> reindex (phatform) >> maxKey (layout) >> objectToArray (calendar) All of these will stay. >> >>Database.php: sqlFriendlyName (phatform) >> sqlImport (setup/boost specific) >> - I figure sqlImport and all the helper functions can be >> included with boost and setup (when they run) >> >>Form.php: clock (calendar) >> alphabet (users) >> >>WizardBag.php: whereami (comments) >> >> All of these will stay except for sqlImport, Matt could you move this into boost and setup. -- Steven Levin Electronic Student Services Appalachian State University Phone: 828.262.2431 PhpWebsite Development Team URL: http://phpwebsite.appstate.edu Email: st...@NO... |