From: Don S. <do...@se...> - 2004-09-09 21:49:58
|
I was ready to test version 0.10.0 of phpwsbb, however boost didn't think it was an update. I had feared this but had never come to an 0.10.0 to see it in action. Anyway it looks like this is the check in boost: if ($version && $version > $moduleInfo["version"]) Obviously we shouldn't be doing a numerical comparison here. I'm not sure if we can force an alphabetical comparison or if that is even right as well. I have to rush off now but thought I'd throw this out and see if anyone gets a fix before I do. This needs to be corrected otherwise you limit yourself to single-digit minor/patch versions. Don. --=20 Don Seiler do...@se... Public Key: http://pgp.mit.edu:11371/pks/lookup?op=3Dget&search=3D0xFC87F041 Fingerprint: 0B56 50D5 E91E 4D4C 83B7 207C 76AC 5DA2 FC87 F041 |
From: Don S. <do...@se...> - 2004-09-09 21:54:50
|
Thanks to rhalff who pointed me to: http://us2.php.net/manual/en/function.version-compare.php I've tested it and it works great, the user comments show it to be pretty robust. I've taken the liberty of changing Boost.php to use it. Note that all module developers should be using as well in their update.php when checking their own versions. Don. On 16:27 Thu 09 Sep , Don Seiler wrote: > I was ready to test version 0.10.0 of phpwsbb, however boost didn't > think it was an update. I had feared this but had never come to an > 0.10.0 to see it in action. Anyway it looks like this is the check in > boost: >=20 > if ($version && $version > $moduleInfo["version"]) >=20 > Obviously we shouldn't be doing a numerical comparison here. I'm not > sure if we can force an alphabetical comparison or if that is even right > as well. I have to rush off now but thought I'd throw this out and see > if anyone gets a fix before I do. >=20 > This needs to be corrected otherwise you limit yourself to single-digit > minor/patch versions. >=20 > Don. >=20 > --=20 > Don Seiler > do...@se... >=20 > Public Key: http://pgp.mit.edu:11371/pks/lookup?op=3Dget&search=3D0xFC87F= 041 > Fingerprint: 0B56 50D5 E91E 4D4C 83B7 207C 76AC 5DA2 FC87 F041 --=20 Don Seiler do...@se... Public Key: http://pgp.mit.edu:11371/pks/lookup?op=3Dget&search=3D0xFC87F041 Fingerprint: 0B56 50D5 E91E 4D4C 83B7 207C 76AC 5DA2 FC87 F041 |
From: Wendall C. <wen...@to...> - 2004-09-09 22:40:39
|
Don, I've ran into this before with minor version changes. It is freaky at times the way things are. Some version numbers will not boost at all. I think I ran into this for 0.3.x or 0.2.x on rssfeeds. I'll update my local cvs and test against a couple things as well. Wendall On Thu, 2004-09-09 at 14:54, Don Seiler wrote: > Thanks to rhalff who pointed me to: > > http://us2.php.net/manual/en/function.version-compare.php > > I've tested it and it works great, the user comments show it to be > pretty robust. > > I've taken the liberty of changing Boost.php to use it. Note that all > module developers should be using as well in their update.php when > checking their own versions. > > Don. > > On 16:27 Thu 09 Sep , Don Seiler wrote: > > I was ready to test version 0.10.0 of phpwsbb, however boost didn't > > think it was an update. I had feared this but had never come to an > > 0.10.0 to see it in action. Anyway it looks like this is the check in > > boost: > > > > if ($version && $version > $moduleInfo["version"]) > > > > Obviously we shouldn't be doing a numerical comparison here. I'm not > > sure if we can force an alphabetical comparison or if that is even right > > as well. I have to rush off now but thought I'd throw this out and see > > if anyone gets a fix before I do. > > > > This needs to be corrected otherwise you limit yourself to single-digit > > minor/patch versions. > > > > Don. > > > > -- > > Don Seiler > > do...@se... > > > > Public Key: http://pgp.mit.edu:11371/pks/lookup?op=get&search=0xFC87F041 > > Fingerprint: 0B56 50D5 E91E 4D4C 83B7 207C 76AC 5DA2 FC87 F041 -- "Only the ideas that we really live have any value." --Hermann Hesse (Demian) |
From: Shaun M. <sh...@ae...> - 2004-09-09 23:33:15
|
On 9 Sep 2004, at 22:27, Don Seiler wrote: > I was ready to test version 0.10.0 of phpwsbb, Isn't that a little confusing to humans though? ie. is 0.10 > 0.9? Go on, have the balls to call it 1.0. ;-) Shaun aegis design - http://www.aegisdesign.co.uk |