Menu
▾
▴
|
From: Alessandro P. (T. / J578) <al...@ti...> - 2001-11-30 11:39:08
|
I've just committed two small fixes to stabilize upgrade from 0.8.1-official to CVS and to complete a previous fix in polls. As far as I can see, upgrading from 0.8.1 to CVS is now safe. I'm also investigating old (zombies) pending bugs, support requests and features requests (some of them had been superceded by 0.8.x releases) : expect a loss of opened-items in the next days... I hope :> Today I'm going to officially start work onto the new themes configuration module, along with a minor enhancement to userpages editor. I'm also investigation on a bug which fix should require all $op to be lowercase. This change would avoid broken themes etc. to create some common errors. What d'you think of it? It would be okay to operate this change? - Bug is #486810 Ah, last but not least: I would thank all those people who sent me (both in ml, both privately) feedback on the planned language system : I'll soon post a detailed plan about it. Regards, Alessandro -- Alessandro "TXM" Pisani - al...@ti... - ICQ #2209087 INWO Project coordinator http://www.inwoproject.f2s.com "I will carry you through, hicking and screaming, and in the end you will thank me" - Tyler Durden [from "Fight Club"] |
|
From: Karsten D. <k.d...@tu...> - 2001-11-30 14:20:10
|
On Fri, Nov 30, 2001 at 12:35:31PM +0100, Alessandro Pisani (TXM / J578) wrote: > I'm also investigation on a bug which fix should require all $op to be > lowercase. This change would avoid broken themes etc. to create some > common errors. What d'you think of it? It would be okay to operate this > change? - Bug is #486810 I would go for it. Calling strtolower on $op seems to be a good thing, it makes the system far more robust. And it shoudl break next to nothing - relying on case-sesitivity when distinguishing operations would seem unlikely. Karsten -- Why do we have to hide from the police, daddy? Because we use emacs, son. They use vi. ----------------------------- mailto:k.d...@tu... w³: http://www.k-fish.de/ gpg: http://www.k-fish.de/mykeys.gpg |
|
From: Alessandro P. (T. / J578) <al...@ti...> - 2001-11-30 15:24:29
|
On Fri, 2001-11-30 at 16:04, Karsten Dambekalns wrote: > On Fri, Nov 30, 2001 at 03:21:44PM +0100, Alessandro Pisani (TXM / J578) wrote: > > On Fri, 2001-11-30 at 15:17, Karsten Dambekalns wrote: > > > On Fri, Nov 30, 2001 at 12:35:31PM +0100, Alessandro Pisani (TXM / J578) wrote: > > > > > > > I'm also investigation on a bug which fix should require all $op to be > > > > lowercase. This change would avoid broken themes etc. to create some > > > > common errors. What d'you think of it? It would be okay to operate this > > > > change? - Bug is #486810 > > > > > > I would go for it. Calling strtolower on $op seems to be a good thing, > > > it makes the system far more robust. And it shoudl break next to > > > nothing - relying on case-sesitivity when distinguishing operations > > > would seem unlikely. > > This should require changes in about 90% of modules, so this is why I > > was asking comments on how to move :> > > Huh?!? [grumblegrumble] Oh no! > > You are right. Maybe I should have looked at the switches spread all > over the place one more time. Indeed, a wild mixture of "ChangePoll" > and "menu_post" style statements. Hmmm. > > Well, should be cleaned up anyway, I guess. Do we have a coding > guideline for this case (too lazy to look right now)? If not, we > should raise the issue on the dev list more offensive... I agree. We need a coding guideline for $op... I forward this topic to the dev mail-list. Bye, Alessandro -- Alessandro "TXM" Pisani - al...@ti... - ICQ #2209087 INWO Project coordinator http://www.inwoproject.f2s.com "I will carry you through, hicking and screaming, and in the end you will thank me" - Tyler Durden [from "Fight Club"] |
|
From: Brian W. B. <br...@tu...> - 2001-11-30 16:09:17
|
>> Well, should be cleaned up anyway, I guess. Do we have a >> coding >> guideline for this case (too lazy to look right now)? If >> not, we should raise the issue on the dev list more >> offensive... > I agree. We need a coding guideline for $op... I forward > this topic to the dev mail-list. See: http://www.k-fish.de/krabutzig/phpwebsite/devdoc.html and http://res1.stddev.appstate.edu/cvs/checkout.php/phpwebsite/docs/MODULES_README?r=1.10 and http://phpwebsite.appstate.edu/mod.php?mod=userpage&menu=1503&page_id=21 (Note that we *really* need to try to bring things up to the PEAR standards...) Brian -- Brian W. Brown Director, Electronic Student Services Student Development Room 269, John Thomas Hall Appalachian State University Boone, NC 28608 vox: 828-262-7124 fax: 828-262-2585 L I N U X .~. /V\ // \\ /( )\ ^^-^^ Love the Penguin |
|
From: Alessandro P. (T. / J578) <al...@ti...> - 2001-11-30 16:29:00
|
On Fri, 2001-11-30 at 17:04, Brian W. Brown wrote: > See: > > http://www.k-fish.de/krabutzig/phpwebsite/devdoc.html > > and > > http://res1.stddev.appstate.edu/cvs/checkout.php/phpwebsite/docs/MODULES_README?r=1.10 > and > > http://phpwebsite.appstate.edu/mod.php?mod=userpage&menu=1503&page_id=21 Thanks.... but I think we need to add to these guidelines a raccomandation on $op : bug #486810 show us that admitting case-sensitive $op can cause problem when third-party themes or modules are not very well written. The user who reported #486810 suggested to force switch(strtolower($op)) intead of the current switch($op), but this would require a lot of changes in both phpWS core and modules; furthermore it can breaks up backward-compatibility. Any idea/comments on this? Kind Regards, Alessandro -- Alessandro "TXM" Pisani - al...@ti... - ICQ #2209087 INWO Project coordinator http://www.inwoproject.f2s.com "I will carry you through, hicking and screaming, and in the end you will thank me" - Tyler Durden [from "Fight Club"] |
