Menu
▾
▴
phpwebsite-developers
|
From: Richard S. <ri...@ri...> - 2003-03-17 23:23:34
|
I see some stuff in the page master module that has useless stuff
like....
if(false){
...code...
}
It looks like it instead of commenting the code, it's been wrapped in a
if statement which is not the best solution. That should cause extra
overhead with PHP. It's just better to comment it, it's faster and less
overhead.
Regards,
Richard S.
PS: Hey Matt, what's up with the Demographics module?
|
|
From: Matthew M. <ma...@tu...> - 2003-03-18 14:04:28
|
> PS: Hey Matt, what's up with the Demographics module? It's on the back burner. We are working on getting 0.9.1 rc1 out and I have several university duties that demand my attention. Since demographics is a pretty big change, I will probably work on it after 0.9.1 stable. Matthew McNaney Internet Systems Architect Electronic Student Services Appalachian State University Phone: 828-262-6493 phpwebsite.appstate.edu ess.appstate.edu |
|
From: Richard S. <ri...@ri...> - 2003-03-18 19:27:51
|
Cool... Just to update everyone on the mailing list, what is the PHPWebSite team up to right now? On Tuesday, March 18, 2003, at 06:09 AM, Matthew McNaney wrote: >> PS: Hey Matt, what's up with the Demographics module? > > It's on the back burner. We are working on getting 0.9.1 rc1 out and I > have several university duties that demand my attention. Since > demographics is a pretty big change, I will probably work on it after > 0.9.1 stable. > > Matthew McNaney > Internet Systems Architect > Electronic Student Services > Appalachian State University > Phone: 828-262-6493 > phpwebsite.appstate.edu > ess.appstate.edu > > > ------------------------------------------------------- > This SF.net email is sponsored by: Does your code think in ink? > You could win a Tablet PC. Get a free Tablet PC hat just for playing. > What are you waiting for? > http://ads.sourceforge.net/cgi-bin/redirect.pl?micr5043en > _______________________________________________ > Phpwebsite-developers mailing list > Php...@li... > https://lists.sourceforge.net/lists/listinfo/phpwebsite-developers > > > Richard Sumilang IT Manager ExexDirect, LLC 21650 Oxnard St., Suite 2350 Woodland Hills, CA 91367 (877) 591-3252 rsu...@ex... www.exexdirect.com |
|
From: Don S. <do...@se...> - 2003-03-18 23:21:06
|
Knee-deep in women and gin. Don. On Tue, 18 Mar 2003, Richard Sumilang wrote: > Cool... Just to update everyone on the mailing list, what is the > PHPWebSite team up to right now? > > On Tuesday, March 18, 2003, at 06:09 AM, Matthew McNaney wrote: > > >> PS: Hey Matt, what's up with the Demographics module? > > > > It's on the back burner. We are working on getting 0.9.1 rc1 out and I > > have several university duties that demand my attention. Since > > demographics is a pretty big change, I will probably work on it after > > 0.9.1 stable. > > > > Matthew McNaney > > Internet Systems Architect > > Electronic Student Services > > Appalachian State University > > Phone: 828-262-6493 > > phpwebsite.appstate.edu > > ess.appstate.edu > > > > > > ------------------------------------------------------- > > This SF.net email is sponsored by: Does your code think in ink? > > You could win a Tablet PC. Get a free Tablet PC hat just for playing. > > What are you waiting for? > > http://ads.sourceforge.net/cgi-bin/redirect.pl?micr5043en > > _______________________________________________ > > Phpwebsite-developers mailing list > > Php...@li... > > https://lists.sourceforge.net/lists/listinfo/phpwebsite-developers > > > > > > > > > Richard Sumilang > IT Manager > ExexDirect, LLC > 21650 Oxnard St., Suite 2350 > Woodland Hills, CA 91367 > (877) 591-3252 > rsu...@ex... > www.exexdirect.com > > > > ------------------------------------------------------- > This SF.net email is sponsored by: Does your code think in ink? > You could win a Tablet PC. Get a free Tablet PC hat just for playing. > What are you waiting for? > http://ads.sourceforge.net/cgi-bin/redirect.pl?micr5043en > _______________________________________________ > Phpwebsite-developers mailing list > Php...@li... > https://lists.sourceforge.net/lists/listinfo/phpwebsite-developers > > > |
|
From: Matthew M. <ma...@tu...> - 2003-03-19 12:53:31
|
Exactly! Actually now that 0.9.0 is out, everyone on campus wants it so we have to convert themes, sites, etc. Meanwhile be on the look out for 0.9.1 rc1 coming soon to web site near you. Matt > Knee-deep in women and gin. > > Don. > > On Tue, 18 Mar 2003, Richard Sumilang wrote: > >> Cool... Just to update everyone on the mailing list, what is the >> PHPWebSite team up to right now? >> >> On Tuesday, March 18, 2003, at 06:09 AM, Matthew McNaney wrote: >> >> >> PS: Hey Matt, what's up with the Demographics module? >> > >> > It's on the back burner. We are working on getting 0.9.1 rc1 out and I >> > have several university duties that demand my attention. Since >> > demographics is a pretty big change, I will probably work on it after >> > 0.9.1 stable. >> > >> > Matthew McNaney >> > Internet Systems Architect >> > Electronic Student Services >> > Appalachian State University >> > Phone: 828-262-6493 >> > phpwebsite.appstate.edu >> > ess.appstate.edu >> > >> > >> > ------------------------------------------------------- >> > This SF.net email is sponsored by: Does your code think in ink? >> > You could win a Tablet PC. Get a free Tablet PC hat just for playing. >> > What are you waiting for? >> > http://ads.sourceforge.net/cgi-bin/redirect.pl?micr5043en >> > _______________________________________________ >> > Phpwebsite-developers mailing list >> > Php...@li... >> > https://lists.sourceforge.net/lists/listinfo/phpwebsite-developers >> > >> > >> > >> >> >> Richard Sumilang >> IT Manager >> ExexDirect, LLC >> 21650 Oxnard St., Suite 2350 >> Woodland Hills, CA 91367 >> (877) 591-3252 >> rsu...@ex... >> www.exexdirect.com >> >> >> >> ------------------------------------------------------- >> This SF.net email is sponsored by: Does your code think in ink? >> You could win a Tablet PC. Get a free Tablet PC hat just for playing. >> What are you waiting for? >> http://ads.sourceforge.net/cgi-bin/redirect.pl?micr5043en >> _______________________________________________ >> Phpwebsite-developers mailing list >> Php...@li... >> https://lists.sourceforge.net/lists/listinfo/phpwebsite-developers >> >> >> > > > ------------------------------------------------------- > This SF.net email is sponsored by: Does your code think in ink? > You could win a Tablet PC. Get a free Tablet PC hat just for playing. > What are you waiting for? > http://ads.sourceforge.net/cgi-bin/redirect.pl?micr5043en > _______________________________________________ > Phpwebsite-developers mailing list > Php...@li... > https://lists.sourceforge.net/lists/listinfo/phpwebsite-developers > |
|
From: Richard S. <rsu...@ex...> - 2003-03-18 18:49:38
|
Cool... Just to update everyone on the mailing list, what is the PHPWebSite team up to right now? On Tuesday, March 18, 2003, at 06:09 AM, Matthew McNaney wrote: >> PS: Hey Matt, what's up with the Demographics module? > > It's on the back burner. We are working on getting 0.9.1 rc1 out and I > have several university duties that demand my attention. Since > demographics is a pretty big change, I will probably work on it after > 0.9.1 stable. > > Matthew McNaney > Internet Systems Architect > Electronic Student Services > Appalachian State University > Phone: 828-262-6493 > phpwebsite.appstate.edu > ess.appstate.edu > > > ------------------------------------------------------- > This SF.net email is sponsored by: Does your code think in ink? > You could win a Tablet PC. Get a free Tablet PC hat just for playing. > What are you waiting for? > http://ads.sourceforge.net/cgi-bin/redirect.pl?micr5043en > _______________________________________________ > Phpwebsite-developers mailing list > Php...@li... > https://lists.sourceforge.net/lists/listinfo/phpwebsite-developers > > > Richard Sumilang IT Manager ExexDirect, LLC 21650 Oxnard St., Suite 2350 Woodland Hills, CA 91367 (877) 591-3252 rsu...@ex... www.exexdirect.com |
|
From: Matthew M. <ma...@tu...> - 2003-03-20 12:56:43
|
> Cool... Just to update everyone on the mailing list, what is the > PHPWebSite team up to right now? I can't get into the university projects (it would take too long :) ). phpWebSite-wise we are getting prepared to release 0.9.1 rc1. Check out CVS if you wish to see up-to-the-minute things we have been working on. Matthew McNaney Internet Systems Architect Electronic Student Services Appalachian State University Phone: 828-262-6493 phpwebsite.appstate.edu ess.appstate.edu |
|
From: <ad...@tu...> - 2003-03-19 17:03:07
|
> I see some stuff in the page master module that has useless stuff
> like....
>
> if(false){
> ...code...
> }
I will look into this today.
Adam
--
Adam Morton
Developer - Electronic Student Services
http://phpwebsite.appstate.edu
Founder - Appalachian Linux Users Group
http://alug.appstate.edu
|
|
From: <ad...@tu...> - 2003-03-19 20:17:55
|
> I see some stuff in the page master module that has useless stuff
> like....
>
> if(false){
> ...code...
> }
Hey Richard,
I looked through the code in all the class files and only found 2 if
statements that were questionable. The code they wrapped simply set a
variable to NULL but it looked like that would never happen anyway. I
could not find anything aiken to:
if(false)
-or-
if(0)
Can you give me some filenames and line numbers where you think this is
occuring. Please check the cvs version of the files. Also look at the
places where I commented out 2 if statements and see if those were the
culprits (Page.php line 251 and Section.php line 209). If there is more
out there, let me know.
Adam
--
Adam Morton
Developer - Electronic Student Services
http://phpwebsite.appstate.edu
Founder - Appalachian Linux Users Group
http://alug.appstate.edu
|
|
From: <ad...@tu...> - 2003-03-19 20:41:20
|
I just added some code to Page.php that moved those line numbers I gave
you, it's now Page.php line 257.
Adam
>> I see some stuff in the page master module that has useless stuff
>> like....
>>
>> if(false){
>> ...code...
>> }
>
> Hey Richard,
>
> I looked through the code in all the class files and only found 2 if
> statements that were questionable. The code they wrapped simply set a
> variable to NULL but it looked like that would never happen anyway. I
> could not find anything aiken to:
>
> if(false)
>
> -or-
>
> if(0)
>
> Can you give me some filenames and line numbers where you think this is
> occuring. Please check the cvs version of the files. Also look at the
> places where I commented out 2 if statements and see if those were the
> culprits (Page.php line 251 and Section.php line 209). If there is more
> out there, let me know.
>
> Adam
>
> --
> Adam Morton
> Developer - Electronic Student Services
> http://phpwebsite.appstate.edu
> Founder - Appalachian Linux Users Group
> http://alug.appstate.edu
>
>
>
> -------------------------------------------------------
> This SF.net email is sponsored by: Does your code think in ink?
> You could win a Tablet PC. Get a free Tablet PC hat just for playing.
> What are you waiting for?
> http://ads.sourceforge.net/cgi-bin/redirect.pl?micr5043en
> _______________________________________________
> Phpwebsite-developers mailing list
> Php...@li...
> https://lists.sourceforge.net/lists/listinfo/phpwebsite-developers
>
--
Adam Morton
Developer - Electronic Student Services
http://phpwebsite.appstate.edu
Founder - Appalachian Linux Users Group
http://alug.appstate.edu
|
|
From: Matthew M. <ma...@tu...> - 2003-03-21 14:38:12
|
> I see some stuff in the page master module that has useless stuff
> like....
>
> if(false){
> ...code...
> }
I just saw this today while working on some bugs. This was my doing. The
reason that you may see !isset($GLOBALS['CNT_VAR']) is because we are
concatenating text in the function. The function does not know if the
variable is set or not and if you concatenate on an unset variable, you
get a notice message.
This has been streamlined to just declare the global variable to null in
the index.
My appologies to Adam who was probably unaware of where this code came from.
Matthew McNaney
Internet Systems Architect
Electronic Student Services
Appalachian State University
Phone: 828-262-6493
phpwebsite.appstate.edu
ess.appstate.edu
|
|
From: Don S. <do...@se...> - 2003-03-21 14:42:30
|
You would still need to do those isset checks for REQUEST vars though,
correct?
Don.
On Fri, 21 Mar 2003, Matthew McNaney wrote:
> > I see some stuff in the page master module that has useless stuff
> > like....
> >
> > if(false){
> > ...code...
> > }
>
> I just saw this today while working on some bugs. This was my doing. The
> reason that you may see !isset($GLOBALS['CNT_VAR']) is because we are
> concatenating text in the function. The function does not know if the
> variable is set or not and if you concatenate on an unset variable, you
> get a notice message.
>
> This has been streamlined to just declare the global variable to null in
> the index.
>
> My appologies to Adam who was probably unaware of where this code came from.
>
> Matthew McNaney
> Internet Systems Architect
> Electronic Student Services
> Appalachian State University
> Phone: 828-262-6493
> phpwebsite.appstate.edu
> ess.appstate.edu
>
>
> -------------------------------------------------------
> This sf.net email is sponsored by:ThinkGeek
> Welcome to geek heaven.
> http://thinkgeek.com/sf
> _______________________________________________
> Phpwebsite-developers mailing list
> Php...@li...
> https://lists.sourceforge.net/lists/listinfo/phpwebsite-developers
>
>
>
|
|
From: Matthew M. <ma...@tu...> - 2003-03-21 15:11:52
|
> You would still need to do those isset checks for REQUEST vars though, > correct? Correct. If you are performing functions on $_SESSIONS, $_POST, $_GET, and $_REQUEST and you are not sure if they are preset, use isset to make sure. Otherwise you will get a notice or warning. Matthew McNaney Internet Systems Architect Electronic Student Services Appalachian State University Phone: 828-262-6493 phpwebsite.appstate.edu ess.appstate.edu |
×
Want the latest updates on software, tech news, and AI?
Get latest updates about software, tech news, and AI from SourceForge directly in your inbox once a month.
Thanks for helping keep SourceForge clean.
X