Thread: [Phpwebsite-developers] About bug #485294: banner is inserted outside of body

Brought to you by: brownbw, jtickle, verdonv

phpwebsite-developers

[Phpwebsite-developers] About bug #485294: banner is inserted outside of body

From: Karsten D. <k.d...@tu...> - 2001-11-29 16:11:52

Hi!

I started working on my bug "#485294 banner is inserted outside of
body", and came across the following:

The banner is included before the call to head, this way it has to be
just after the xml declaration and even before the html tag.

The only way to solve this, is to put the call to the banner functions
into the theme's header file (right after the opening body tag). While
this works for me without a hitch, it would need modifications to all
existing themes (at least the ones whose authors want their themes to
support banners).

What do you think? Is this a show-stopper? Or are both states equally
bad (having to change all themes vs. having invalid XHTML when using
banners)?

Looking forward to your opinions!
Karsten
-- 
Why do we have to hide from the police, daddy?
Because we use emacs, son. They use vi.
-----------------------------
mailto:k.d...@tu... w³: http://www.k-fish.de/
gpg: http://www.k-fish.de/mykeys.gpg

Re: [Phpwebsite-developers] About bug #485294: banner is inserted outside of body

From: Alessandro P. (T. / J578) <al...@ti...> - 2001-11-29 16:23:12

On Thu, 2001-11-29 at 16:59, Karsten Dambekalns wrote:
> The only way to solve this, is to put the call to the banner functions
> into the theme's header file (right after the opening body tag). While
> this works for me without a hitch, it would need modifications to all
> existing themes (at least the ones whose authors want their themes to
> support banners).
> 
> What do you think? Is this a show-stopper? Or are both states equally
> bad (having to change all themes vs. having invalid XHTML when using
> banners)?
> 
> Looking forward to your opinions!
> Karsten
This is not a problem, IMHO.
The themes structure had yet changed from 0.8.1 to CVS to include new
features (such as poll-docking) and others assorted fixes; it also
changed both during 0.7.x branch (as far as I could see) and 0.8.x, so
definitively making it "stable" with all the changes that are needed is
not a backward-compatibility problem (anymore).

>Why do we have to hide from the police, daddy?
>Because we use emacs, son. They use vi.
LOL! Btw I'm a policeman: i've ever hated emacs (maybe I'm too stupid to
understand it ? ...who knows...) ;->

Kind Regards,
Alessandro

-- 
Alessandro "TXM" Pisani - al...@ti... - ICQ #2209087
INWO Project coordinator http://www.inwoproject.f2s.com

"I will carry you through, hicking and screaming,
 and in the end you will thank me"
 - Tyler Durden [from "Fight Club"]

Re: [Phpwebsite-developers] About bug #485294: banner is inserted outside

From: Matthew M. <ma...@tu...> - 2001-11-29 16:38:51

Hey Karsten,

> The only way to solve this, is to put the call to the banner functions
> into the theme's header file (right after the opening body tag). While
> this works for me without a hitch, it would need modifications to all
> existing themes (at least the ones whose authors want their themes to
> support banners).
> What do you think? Is this a show-stopper? Or are both states equally
> bad (having to change all themes vs. having invalid XHTML when using
> banners)?

I think changing the individual theme might be the best route. We will just
need to make mention of it to the people who upgrade. I am guessing the
code will probably be pretty short.

From a PR point of view, we might want to make a sample theme that uses the
banner effectively. Currently, the banner is pretty much out of place. If
we introduce it in the theme/foo/header.php file yet incorporate instead of
it sitting outside the theme (as it does currently) people may appreciate
it more.

Best regards,
Matt

Matthew McNaney
Internet Systems Architect
Electronic Student Services
Email: ma...@tu...
URL: http://phpwebsite.appstate.edu
Phone: 828-262-6493

RE: [Phpwebsite-developers] About bug #485294: banner is inserted outside

From: Vlad S. <vl...@hu...> - 2001-11-29 17:28:10

aSBhZ3JlZSAtIGkgdGhpbmsgdGhlIGJhbm5lciBjYWxsIHNob3VsZCBnbyBpbnRvIHRoZSB0aGVt
ZSBkZWZpbml0aW9uIHJlZ2FyZGxlc3MuLi4NCg0KdG9wIG9mIHRoZSBwYWdlIGlzIGNvbnNpZGVy
ZWQgc2FjcmVkIGZvciBhIGxvdCBvZiBhZXN0aGV0aWNhbGx5IGluY2xpbmVkIHdlYiBkZXZlbG9w
ZXJzLiBCYW5uZXIgb24gdG9wIGVhdHMgdXAgcXVpdGUgYSBiaXQgb2YgaGVhZGVyIHNwYWNlIGFu
ZCBzaGlmdHMgbW9yZSBpbXBvcnRhbnQgY29udGVudCBkb3duLiBzbywgd2h5IG5vdCBsZXQgdGhl
IGRldmVsb3BlciBkZWNpZGUgd2hlcmUgdGhlIGJhbm5lciBzaG91bGQgZ28/Li4NCg0KDQpWbGFk
DQoNClAuUy4gUEhQV2Vic2l0ZSBpcyBhIGtpY2sgYXNzIHByb2R1Y3QuIEkndmUgdHJpZWQgYWJv
dXQgMzAgZGlmZmVyZW50IEdQTCBhbmQgbm9uLUdQTCBDTVMncyAsIGFuZCBmcmFua2x5LCBtb3N0
IG9mIHRoZW0gc3VjayAodXN1YWxseSBlaXRoZXIgc3BlZWQgb3IgZWFzZSBvZiBtYWludGVuYW5j
ZSBpc3N1ZXMpLiBrZWVwIHVwIHRoZSBnb29kIHdvcmsuIA0KDQoNCj4gLS0tLS1PcmlnaW5hbCBN
ZXNzYWdlLS0tLS0NCj4gRnJvbTogcGhwd2Vic2l0ZS1kZXZlbG9wZXJzLWFkbWluQGxpc3RzLnNv
dXJjZWZvcmdlLm5ldA0KPiBbbWFpbHRvOnBocHdlYnNpdGUtZGV2ZWxvcGVycy1hZG1pbkBsaXN0
cy5zb3VyY2Vmb3JnZS5uZXRdT24gQmVoYWxmIE9mDQo+IE1hdHRoZXcgTWNOYW5leQ0KPiBTZW50
OiBUaHVyc2RheSwgTm92ZW1iZXIgMjksIDIwMDEgMTA6MzQgYW0NCj4gVG86IHBocHdlYnNpdGUt
ZGV2ZWxvcGVyc0BsaXN0cy5zb3VyY2Vmb3JnZS5uZXQNCj4gU3ViamVjdDogUmU6IFtQaHB3ZWJz
aXRlLWRldmVsb3BlcnNdIEFib3V0IGJ1ZyAjNDg1Mjk0OiBiYW5uZXIgaXMNCj4gaW5zZXJ0ZWQg
b3V0c2lkZQ0KPiANCj4gDQo+IEhleSBLYXJzdGVuLA0KPiANCj4gPiBUaGUgb25seSB3YXkgdG8g
c29sdmUgdGhpcywgaXMgdG8gcHV0IHRoZSBjYWxsIHRvIHRoZSBiYW5uZXIgZnVuY3Rpb25zDQo+
ID4gaW50byB0aGUgdGhlbWUncyBoZWFkZXIgZmlsZSAocmlnaHQgYWZ0ZXIgdGhlIG9wZW5pbmcg
Ym9keSB0YWcpLiBXaGlsZQ0KPiA+IHRoaXMgd29ya3MgZm9yIG1lIHdpdGhvdXQgYSBoaXRjaCwg
aXQgd291bGQgbmVlZCBtb2RpZmljYXRpb25zIHRvIGFsbA0KPiA+IGV4aXN0aW5nIHRoZW1lcyAo
YXQgbGVhc3QgdGhlIG9uZXMgd2hvc2UgYXV0aG9ycyB3YW50IHRoZWlyIHRoZW1lcyB0bw0KPiA+
IHN1cHBvcnQgYmFubmVycykuDQo+ID4gV2hhdCBkbyB5b3UgdGhpbms/IElzIHRoaXMgYSBzaG93
LXN0b3BwZXI/IE9yIGFyZSBib3RoIHN0YXRlcyBlcXVhbGx5DQo+ID4gYmFkIChoYXZpbmcgdG8g
Y2hhbmdlIGFsbCB0aGVtZXMgdnMuIGhhdmluZyBpbnZhbGlkIFhIVE1MIHdoZW4gdXNpbmcNCj4g
PiBiYW5uZXJzKT8NCj4gDQo+IEkgdGhpbmsgY2hhbmdpbmcgdGhlIGluZGl2aWR1YWwgdGhlbWUg
bWlnaHQgYmUgdGhlIGJlc3Qgcm91dGUuIFdlIA0KPiB3aWxsIGp1c3QNCj4gbmVlZCB0byBtYWtl
IG1lbnRpb24gb2YgaXQgdG8gdGhlIHBlb3BsZSB3aG8gdXBncmFkZS4gSSBhbSBndWVzc2luZyB0
aGUNCj4gY29kZSB3aWxsIHByb2JhYmx5IGJlIHByZXR0eSBzaG9ydC4NCj4gDQo+ID5Gcm9tIGEg
UFIgcG9pbnQgb2Ygdmlldywgd2UgbWlnaHQgd2FudCB0byBtYWtlIGEgc2FtcGxlIHRoZW1lIA0K
PiB0aGF0IHVzZXMgdGhlDQo+IGJhbm5lciBlZmZlY3RpdmVseS4gQ3VycmVudGx5LCB0aGUgYmFu
bmVyIGlzIHByZXR0eSBtdWNoIG91dCBvZiBwbGFjZS4gSWYNCj4gd2UgaW50cm9kdWNlIGl0IGlu
IHRoZSB0aGVtZS9mb28vaGVhZGVyLnBocCBmaWxlIHlldCBpbmNvcnBvcmF0ZSANCj4gaW5zdGVh
ZCBvZg0KPiBpdCBzaXR0aW5nIG91dHNpZGUgdGhlIHRoZW1lIChhcyBpdCBkb2VzIGN1cnJlbnRs
eSkgcGVvcGxlIG1heSBhcHByZWNpYXRlDQo+IGl0IG1vcmUuDQo+IA0KPiBCZXN0IHJlZ2FyZHMs
DQo+IE1hdHQNCj4gDQo+IE1hdHRoZXcgTWNOYW5leQ0KPiBJbnRlcm5ldCBTeXN0ZW1zIEFyY2hp
dGVjdA0KPiBFbGVjdHJvbmljIFN0dWRlbnQgU2VydmljZXMNCj4gRW1haWw6IG1hdHRAdHV4LmFw
cHN0YXRlLmVkdQ0KPiBVUkw6IGh0dHA6Ly9waHB3ZWJzaXRlLmFwcHN0YXRlLmVkdQ0KPiBQaG9u
ZTogODI4LTI2Mi02NDkzDQo+IA0KPiANCj4gDQo+IF9fX19fX19fX19fX19fX19fX19fX19fX19f
X19fX19fX19fX19fX19fX19fX19fDQo+IFBocHdlYnNpdGUtZGV2ZWxvcGVycyBtYWlsaW5nIGxp
c3QNCj4gUGhwd2Vic2l0ZS1kZXZlbG9wZXJzQGxpc3RzLnNvdXJjZWZvcmdlLm5ldA0KPiBodHRw
czovL2xpc3RzLnNvdXJjZWZvcmdlLm5ldC9saXN0cy9saXN0aW5mby9waHB3ZWJzaXRlLWRldmVs
b3BlcnMNCj4g

[Phpwebsite-developers] Re: About bug #485294: banner is inserted outside

From: Karsten D. <k.d...@tu...> - 2001-12-03 13:41:39

On Thu, Nov 29, 2001 at 11:34:15AM -0500, Matthew McNaney wrote:
> I think changing the individual theme might be the best route. We will just
> need to make mention of it to the people who upgrade. I am guessing the
> code will probably be pretty short.

Yes, short :-) Basically put this into the theme anywhere you like:

<?php
if ($banners)
{
  include("banners.php");
}
?>

It will emit a div tag in which the img is centered. Or should the
function just emit the img tag, without any "container", since the
"container" can as well be placed in the theme file. This way it would
be even more flexible...

Who promotes this change (just committed it to CVS) to the theme
developers? We should probably mention it on phpwebsite.appstate.edu
and on phpwsthemes.sourceforge.net...

> >From a PR point of view, we might want to make a sample theme that uses the
> banner effectively. Currently, the banner is pretty much out of place. If
> we introduce it in the theme/foo/header.php file yet incorporate instead of
> it sitting outside the theme (as it does currently) people may appreciate
> it more.

Definitely a good idea. Who takes care of the "phpWebSite" and the
"Default" theme?

Regards,
Karsten
-- 
Why do we have to hide from the police, daddy?
Because we use emacs, son. They use vi.
-----------------------------
mailto:k.d...@tu... w³: http://www.k-fish.de/
gpg: http://www.k-fish.de/mykeys.gpg

Re: [Phpwebsite-developers] Re: About bug #485294: banner is inserted

From: Matthew M. <ma...@tu...> - 2001-12-03 13:55:15

> Who promotes this change (just committed it to CVS) to the theme
> developers? We should probably mention it on phpwebsite.appstate.edu
> and on phpwsthemes.sourceforge.net...

If you can just remind me before the next version comes out, I'll take care
of it.

> Definitely a good idea. Who takes care of the "phpWebSite" and the
> "Default" theme?

Since you are a developer, you do ;) those are default themes, so if you
want to make the change, go for it. Otherwise, just let me know and I can
do it.

Thanks,
Matt


Matthew McNaney
Internet Systems Architect
Electronic Student Services
Email: ma...@tu...
URL: http://phpwebsite.appstate.edu
Phone: 828-262-6493
ICQ: 141057403

Re: [Phpwebsite-developers] Re: About bug #485294: banner is inserted

From: Alessandro P. (T. / J578) <al...@ti...> - 2001-12-03 14:17:57

On Mon, 2001-12-03 at 14:50, Matthew McNaney wrote:
> > Who promotes this change (just committed it to CVS) to the theme
> > developers? We should probably mention it on phpwebsite.appstate.edu
> > and on phpwsthemes.sourceforge.net...
> 
> If you can just remind me before the next version comes out, I'll take care
> of it.
Please also mention that there is another (big) change in the default
themes: Ryan and me introduced a new poll block both in header.php and
footer.php to deal with the new poll-docking option.
This also need to be issued to theme developers.

> > Definitely a good idea. Who takes care of the "phpWebSite" and the
> > "Default" theme?
All of us! :>

> Since you are a developer, you do ;) those are default themes, so if you
> want to make the change, go for it. Otherwise, just let me know and I can
> do it.
Me too. If you don't have time to apply the change, please feel free to
delegate it me :>

Regards,
Alessandro

-- 
Alessandro "TXM" Pisani - al...@ti... - ICQ #2209087
INWO Project coordinator http://www.inwoproject.f2s.com

"I will carry you through, hicking and screaming,
 and in the end you will thank me"
 - Tyler Durden [from "Fight Club"]

[Phpwebsite-developers] Re: About bug #485294: banner is inserted

From: Karsten D. <k.d...@tu...> - 2001-12-03 17:43:02

On Mon, Dec 03, 2001 at 08:50:32AM -0500, Matthew McNaney wrote:
> > Who promotes this change (just committed it to CVS) to the theme
> > developers? We should probably mention it on phpwebsite.appstate.edu
> > and on phpwsthemes.sourceforge.net...
> 
> If you can just remind me before the next version comes out, I'll take care
> of it.

I'll try to think of it :-)

> > Definitely a good idea. Who takes care of the "phpWebSite" and the
> > "Default" theme?
> 
> Since you are a developer, you do ;) those are default themes, so if you
> want to make the change, go for it. Otherwise, just let me know and I can
> do it.

Well, I changed the themes to work the new way, of course. But I have
no good idea of a way to include the banners in better way from a
designers point of view. So if anyone wants to do this...

Regards,
Karsten
-- 
Why do we have to hide from the police, daddy?
Because we use emacs, son. They use vi.
-----------------------------
mailto:k.d...@tu... w³: http://www.k-fish.de/
gpg: http://www.k-fish.de/mykeys.gpg