From: Matthew M. <ma...@tu...> - 2003-01-21 12:26:49
|
I am going to work on some of things posted in the below: https://sourceforge.net/forum/message.php?msg_id=1839387 However, notice the line about pear having a File.php as well as our core. Suggestion: Rename our File.php file. Discuss: Rename ALL core files to reflect class names (i.e phpws_file.php) Let me know what you think. Matt -- Matthew McNaney Internet Systems Architect Electronic Student Services Appalachian State University Phone: 828-262-6493 phpwebsite.appstate.edu ess.appstate.edu |
From: Don S. <do...@se...> - 2003-01-21 14:44:37
|
+1 I've always been a supporter of having class file names reflect the class names. The java developer in me is creeping back to the fore. Don. On Tue, 21 Jan 2003, Matthew McNaney wrote: > I am going to work on some of things posted in the below: > > https://sourceforge.net/forum/message.php?msg_id=1839387 > > However, notice the line about pear having a File.php as well as our core. > > Suggestion: Rename our File.php file. > Discuss: Rename ALL core files to reflect class names (i.e phpws_file.php) > > Let me know what you think. > > Matt > > > > |
From: Adam M. <ad...@tu...> - 2003-01-21 14:47:48
|
I fixed this issue in cvs just now. I simply put a './' in each of the requires, letting php know that we want the File.php and all other core files in the core directory and not to append the pear include path. Adam > I am going to work on some of things posted in the below: > > https://sourceforge.net/forum/message.php?msg_id=1839387 > > However, notice the line about pear having a File.php as well as our > core. > > Suggestion: Rename our File.php file. > Discuss: Rename ALL core files to reflect class names (i.e > phpws_file.php) > > Let me know what you think. > > Matt > > > > -- > Matthew McNaney > Internet Systems Architect > Electronic Student Services > Appalachian State University > Phone: 828-262-6493 > phpwebsite.appstate.edu > ess.appstate.edu > > > > > > > ------------------------------------------------------- > This SF.NET email is sponsored by: > SourceForge Enterprise Edition + IBM + LinuxWorld = Something 2 See! > http://www.vasoftware.com > _______________________________________________ > Phpwebsite-developers mailing list > Php...@li... > https://lists.sourceforge.net/lists/listinfo/phpwebsite-developers --------------------------------------------------------------------- Adam Morton Developer - Electronic Student Services http://phpwebsite.appstate.edu Founder - Appalachian Linux Users Group http://alug.appstate.edu |
From: Eloi G. <el...@re...> - 2003-01-21 14:55:54
|
+1 for renaming all core files. |
From: Adam M. <ad...@tu...> - 2003-01-21 16:10:07
|
-1 for renaming all the core files. They already reflect the class names. The PHPWS_ appended to the beginning of each class simply designates it as a phpwebsite-specific class and is the same for all core classes. Plus if we made that change, to stick to the standard, every module currently written would have to change their file names as well. As far as the pear stuff goes...i added in a fix to Core.php that will include the correct core files. Adam > I am going to work on some of things posted in the below: > > https://sourceforge.net/forum/message.php?msg_id=1839387 > > However, notice the line about pear having a File.php as well as our > core. > > Suggestion: Rename our File.php file. > Discuss: Rename ALL core files to reflect class names (i.e > phpws_file.php) > > Let me know what you think. > > Matt > > > > -- > Matthew McNaney > Internet Systems Architect > Electronic Student Services > Appalachian State University > Phone: 828-262-6493 > phpwebsite.appstate.edu > ess.appstate.edu > > > > > > > ------------------------------------------------------- > This SF.NET email is sponsored by: > SourceForge Enterprise Edition + IBM + LinuxWorld = Something 2 See! > http://www.vasoftware.com > _______________________________________________ > Phpwebsite-developers mailing list > Php...@li... > https://lists.sourceforge.net/lists/listinfo/phpwebsite-developers --------------------------------------------------------------------- Adam Morton Developer - Electronic Student Services http://phpwebsite.appstate.edu Founder - Appalachian Linux Users Group http://alug.appstate.edu |
From: Steven L. <st...@tu...> - 2003-01-21 17:24:08
|
-1 I agree with Adam Steven > -1 for renaming all the core files. > > They already reflect the class names. The PHPWS_ appended to the > beginning of each class simply designates it as a phpwebsite-specific > class and is the same for all core classes. Plus if we made that > change, to stick to the standard, every module currently written would > have to change their file names as well. > > As far as the pear stuff goes...i added in a fix to Core.php that will > include the correct core files. > > Adam > >> I am going to work on some of things posted in the below: >> >> https://sourceforge.net/forum/message.php?msg_id=1839387 >> >> However, notice the line about pear having a File.php as well as our >> core. >> >> Suggestion: Rename our File.php file. >> Discuss: Rename ALL core files to reflect class names (i.e >> phpws_file.php) >> >> Let me know what you think. >> >> Matt >> >> >> >> -- >> Matthew McNaney >> Internet Systems Architect >> Electronic Student Services >> Appalachian State University >> Phone: 828-262-6493 >> phpwebsite.appstate.edu >> ess.appstate.edu >> >> >> >> >> >> >> ------------------------------------------------------- >> This SF.NET email is sponsored by: >> SourceForge Enterprise Edition + IBM + LinuxWorld = Something 2 See! >> http://www.vasoftware.com >> _______________________________________________ >> Phpwebsite-developers mailing list >> Php...@li... >> https://lists.sourceforge.net/lists/listinfo/phpwebsite-developers > > > --------------------------------------------------------------------- > Adam Morton > Developer - Electronic Student Services > http://phpwebsite.appstate.edu > Founder - Appalachian Linux Users Group > http://alug.appstate.edu > > > > > ------------------------------------------------------- > This SF.net email is sponsored by: Scholarships for Techies! > Can't afford IT training? All 2003 ictp students receive scholarships. > Get hands-on training in Microsoft, Cisco, Sun, Linux/UNIX, and more. > www.ictp.com/training/sourceforge.asp > _______________________________________________ > Phpwebsite-developers mailing list > Php...@li... > https://lists.sourceforge.net/lists/listinfo/phpwebsite-developers -- Steven Levin Electronic Student Services Appalachian State University Phone: 828.262.2431 PhpWebsite Development Team URL: http://phpwebsite.appstate.edu Email: st...@NO... |