Re: [Phpwebsite-developers] phpWebSite 0.10.3

[Verdon V. <ve...@ve...>]

On 17-Feb-06, at 8:08 AM, Matthew McNaney wrote:

> On Fri, 2006-02-17 at 12:45 +0000, Shaun Murray wrote:

>> Are there any other patches, bugs or RFEs that either need to go in
>> or that would be great additions?
>
> None that I am aware of here at the university.
>

There is one that I just discovered recently and haven't put a bug 
ticket in for yet, as I hadn't had time to decide what recommendation 
to make...

The issue is...

When EZform::saveImage() is used in conjunction with 
PHPWS_File::makeThumbnail() to resize the original image and overwrite 
it on upload -- as is used in a couple of my modules, as well as my 
already committed patch to Announcements, and possibly others -- there 
can be an unexpected result if the image being uploaded has an 
uppercase extension. This happens because EZform::saveImage() 
essentially leaves the filename alone while PHPWS_File::makeThumbnail() 
converts the extension to lowercase. The end result is that 'Image.JPG' 
gets passed to the image data array that is saved to the db, while the 
actual final resized image on the server is named 'Image.jpg', leading 
to problems on a case-sensitive filesystem.

My suggestion would be to do something like have EZform::saveImage() 
convert filenames to lowercase, or some such thing, and I'm willing to 
do it. I just have been too busy and haven't had much time to do more 
than a cursory evaluation of the cause/effect.

best regards,
verdon