Re: [Phpwebsite-developers] boost comparing version numbers incorrectly

[Don S. <do...@se...>]

Thanks to rhalff who pointed me to:

http://us2.php.net/manual/en/function.version-compare.php

I've tested it and it works great, the user comments show it to be
pretty robust.

I've taken the liberty of changing Boost.php to use it.  Note that all
module developers should be using as well in their update.php when
checking their own versions.

Don.

On 16:27 Thu 09 Sep     , Don Seiler wrote:
> I was ready to test version 0.10.0 of phpwsbb, however boost didn't
> think it was an update.  I had feared this but had never come to an
> 0.10.0 to see it in action.  Anyway it looks like this is the check in
> boost:
>=20
>         if ($version && $version > $moduleInfo["version"])
>=20
> Obviously we shouldn't be doing a numerical comparison here.  I'm not
> sure if we can force an alphabetical comparison or if that is even right
> as well.  I have to rush off now but thought I'd throw this out and see
> if anyone gets a fix before I do.
>=20
> This needs to be corrected otherwise you limit yourself to single-digit
> minor/patch versions.
>=20
> Don.
>=20
> --=20
> Don Seiler
> do...@se...
>=20
> Public Key: http://pgp.mit.edu:11371/pks/lookup?op=3Dget&search=3D0xFC87F=
041
> Fingerprint: 0B56 50D5 E91E 4D4C 83B7  207C 76AC 5DA2 FC87 F041



--=20
Don Seiler
do...@se...

Public Key: http://pgp.mit.edu:11371/pks/lookup?op=3Dget&search=3D0xFC87F041
Fingerprint: 0B56 50D5 E91E 4D4C 83B7  207C 76AC 5DA2 FC87 F041