From: Joel K. <jo...@jo...> - 2002-03-08 18:09:18
|
I like seeing that comments threading indentation is finally being properly addressed and fixed in .8.2. I was just about to put in this email that I was going to fix it, and I'm glad to see I don't have to. :) The only comment I have is about how the nesting is currently done. It can be done much more professionally by changing just a few tags. Currently, this is the setup: <blockquote> <a href="link-to-first-toplevel-comment">Comment Title</a> by AUTHOR on DATE-TIME<br /><br /> <blockquote> <a href ="link to first secondlevel comment"> etc. .. </blockquote> <blockquote> <a href="link-to-second-toplevel-comment">Comment Title</a> by AUTHOR on DATE-TIME </blockquote> .. </blockquote> First, I don't see any point for having <br /> in there at all. It just spreads it out. Second, blockquote (at least by default. I haven't found a way to modify it) adds a double-spaced line in between each entry, which makes the page twice as big. My suggestion is to use <ul><li> to get the <br> effect. It's not quite as clean in the code, but it looks much better (this is the way slashcode does its comments). So the new version would look like this: <ul><li> <a href="link-to-first-toplevel-comment">Comment Title</a> by AUTHOR on DATE-TIME <ul><li> <a href ="link to first secondlevel comment"> etc. .. </ul></li> <li> <a href="link-to-second-toplevel-comment">Comment Title</a> by AUTHOR on DATE-TIME </li> .. </ul></li> IMO, that looks a LOT cleaner. At any rate, the indention is a great start, at the very least. One other thing to add would be the Score variable in the Comment link (again, as slashdot does). I look forward to seeing this implemented. Alternatively, I can implement it without any trouble. Joel |