[Phpwebsite-developers] Re: About bug #485294: banner is inserted outside

[Karsten D. <k.d...@tu...>]

On Thu, Nov 29, 2001 at 11:34:15AM -0500, Matthew McNaney wrote:
> I think changing the individual theme might be the best route. We will just
> need to make mention of it to the people who upgrade. I am guessing the
> code will probably be pretty short.

Yes, short :-) Basically put this into the theme anywhere you like:

<?php
if ($banners)
{
  include("banners.php");
}
?>

It will emit a div tag in which the img is centered. Or should the
function just emit the img tag, without any "container", since the
"container" can as well be placed in the theme file. This way it would
be even more flexible...

Who promotes this change (just committed it to CVS) to the theme
developers? We should probably mention it on phpwebsite.appstate.edu
and on phpwsthemes.sourceforge.net...

> >From a PR point of view, we might want to make a sample theme that uses the
> banner effectively. Currently, the banner is pretty much out of place. If
> we introduce it in the theme/foo/header.php file yet incorporate instead of
> it sitting outside the theme (as it does currently) people may appreciate
> it more.

Definitely a good idea. Who takes care of the "phpWebSite" and the
"Default" theme?

Regards,
Karsten
-- 
Why do we have to hide from the police, daddy?
Because we use emacs, son. They use vi.
-----------------------------
mailto:k.d...@tu... w³: http://www.k-fish.de/
gpg: http://www.k-fish.de/mykeys.gpg