Re: [Phpwebsite-developers] CVS stabilization, bugs sweeping and my todo (status report)

[Alessandro P. (T. / J578) <al...@ti...>]

On Fri, 2001-11-30 at 16:04, Karsten Dambekalns wrote:
> On Fri, Nov 30, 2001 at 03:21:44PM +0100, Alessandro Pisani (TXM / J578) wrote:
> > On Fri, 2001-11-30 at 15:17, Karsten Dambekalns wrote:
> > > On Fri, Nov 30, 2001 at 12:35:31PM +0100, Alessandro Pisani (TXM / J578) wrote:
> > > 
> > > > I'm also investigation on a bug which fix should require all $op to be
> > > > lowercase. This change would avoid broken themes etc. to create some
> > > > common errors. What d'you think of it? It would be okay to operate this
> > > > change? - Bug is #486810
> > > 
> > > I would go for it. Calling strtolower on $op seems to be a good thing,
> > > it makes the system far more robust. And it shoudl break next to
> > > nothing - relying on case-sesitivity when distinguishing operations
> > > would seem unlikely.
> > This should require changes in about 90% of modules, so this is why I
> > was asking comments on how to move :>
> 
> Huh?!? [grumblegrumble] Oh no!
> 
> You are right. Maybe I should have looked at the switches spread all
> over the place one more time. Indeed, a wild mixture of "ChangePoll"
> and "menu_post" style statements. Hmmm.
> 
> Well, should be cleaned up anyway, I guess. Do we have a coding
> guideline for this case (too lazy to look right now)? If not, we
> should raise the issue on the dev list more offensive...
I agree. We need a coding guideline for $op... I forward this topic to
the dev mail-list.

Bye,
Alessandro

-- 
Alessandro "TXM" Pisani - al...@ti... - ICQ #2209087
INWO Project coordinator http://www.inwoproject.f2s.com

"I will carry you through, hicking and screaming,
 and in the end you will thank me"
 - Tyler Durden [from "Fight Club"]