Re: [Phpwebsite-developers] About bug #485294: banner is inserted outside

[Matthew M. <ma...@tu...>]

Hey Karsten,

> The only way to solve this, is to put the call to the banner functions
> into the theme's header file (right after the opening body tag). While
> this works for me without a hitch, it would need modifications to all
> existing themes (at least the ones whose authors want their themes to
> support banners).
> What do you think? Is this a show-stopper? Or are both states equally
> bad (having to change all themes vs. having invalid XHTML when using
> banners)?

I think changing the individual theme might be the best route. We will just
need to make mention of it to the people who upgrade. I am guessing the
code will probably be pretty short.

From a PR point of view, we might want to make a sample theme that uses the
banner effectively. Currently, the banner is pretty much out of place. If
we introduce it in the theme/foo/header.php file yet incorporate instead of
it sitting outside the theme (as it does currently) people may appreciate
it more.

Best regards,
Matt

Matthew McNaney
Internet Systems Architect
Electronic Student Services
Email: ma...@tu...
URL: http://phpwebsite.appstate.edu
Phone: 828-262-6493