Menu
▾
▴
[phpws-comm-auto] [ phpwebsite-comm-/mod/article-1037668 ] New articles can't be jumped at directly
|
From: SourceForge.net <no...@so...> - 2007-07-03 20:34:08
|
/mod/article item #1037668, was opened at 2004-09-30 07:47 Message generated for change (Comment added) made by adarkling You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=681146&aid=1037668&group_id=81360 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: None Group: None >Status: Closed Resolution: Accepted Priority: 5 Private: No Submitted By: rck (rck000) Assigned to: Eloi George (adarkling) Summary: New articles can't be jumped at directly Initial Comment: Hi! This ones bugging me since my first phpWebSite install, but I can't hunt it down. I even tried debugging Article Manager myself but got lost in it somewhere. When I finished writing a new article, I often enough announce it somewhere. All at once a couple of people jump directly to such a link (say, http://www.kiesler.at/article85.html) to read it. We're talking about 5 concurrent users or so here. Every time at least someone tells me, he got "I cannot view the article". When I jump directly at that article, with a freshly opened Internet Explorer, I'll get "This article cannot be viewed" as well. That doesn't happen, when the article is shown by clicking on it on my mainpage. The other thing: As soon as the message "this article cannot be viewed" appears, the categories of that article disappear as well. Reference: (german, on my site:) http://www.kiesler.at/index.php? module=phpwsbb&PHPWSBB_MAN_OP=view&PHPWS_MAN _ITEMS[]=109 http://www.kiesler.at/index.php? module=phpwsbb&PHPWSBB_MAN_OP=view&PHPWS_MAN _ITEMS[]=107 regards // Ren ---------------------------------------------------------------------- >Comment By: Eloi George (adarkling) Date: 2007-07-03 16:33 Message: Logged In: YES user_id=619893 Originator: NO Hey rck, I don't know how I missed your last post to this ticket. I don't know if I'd fixed this, but it's a moot point now that AM 4.0 will be released sometime before July 11th. I'm just closing out the old tickets to get ready for the flood of new ones <smile> ---------------------------------------------------------------------- Comment By: rck (rck000) Date: 2004-10-26 04:21 Message: Logged In: YES user_id=1035762 had it again yesterday. I know now, why the fatcat- categories are removed. As soon, as the message "cannot view" is triggered, the following call is made: PHPWS_Fatcat::deactivate($this->id, 'article'); it doesn't make sense to me and seems to remove the categories for the current article. So I've commented it out. Further more, I think, I know where the problem lies. The date check seems strange to me. You render the current time in a variable ($now=date('Y-m-d H:i:s')) and compare it with the publication date and expiry date ($this->publication_date <= $now resp. $this->expiration_date > $now). This seems odd, I don't have a good feeling on this check. I've added a couple of debugging stuff and think, it will trigger around after midnight. I think, the pub and or exp date comparison won't work the way it should around then. function render_not_viewable() { $msg = "The article you requested is not viewable."; return($_SESSION['translate']->it($msg)); } function render_awaiting_approval() { $msg ="The article you requested is awaiting approval by an"; $msg.=" administrator."; return($_SESSION['translate']->it($msg)); } if ($Fullpage && !$this->is_viewable()) { $GLOBALS['CNT_article']['title'] = $_SESSION ['translate']->it('Sorry!'); if($this->approved) $GLOBALS['CNT_article']['content'] = "<p>".$this->render_not_viewable()."\n"; else $GLOBALS['CNT_article']['content'] = "<p>".$this->render_awaiting_approval()."\n"; $GLOBALS['CNT_article']['content'].= $this- >render_debug_viewable(); $GLOBALS['CNT_article']['content'].= $_SESSION['SES_ART_master']->get_error('article')."</p>"; return; /* $_SESSION['translate']->it('The article you requested is awaiting approval by an administrator.'); else $GLOBALS['CNT_article']['content'] = $_SESSION['translate']->it('The article you requested is not viewable.'); */ /* PHPWS_Fatcat::deactivate($this- >id, 'article'); */ return; } function render_yes_no($flag) { if($flag) return('yes'); else return('no'); } function render_debug_viewable() { $now=date('Y-m-d H:i:s'); $main=$this->render_yes_no($this->mainarticle); $pub_date=$this->publication_date; $pub=$this->render_yes_no($pub_date <= $now); $exp_date=$this->expiration_date; $exp=$this->render_yes_no($exp_date > $now); $user=$this->created_username; $can_edit=render_yes_no($_SESSION ['SES_ART_master']->can('edit', $user)); $modart=$this->render_yes_no($GLOBALS ['module']=='article'); $modapp=$this->render_yes_no($GLOBALS ['module']=='approval'); $saving=$this->render_yes_no($saving); $content = "<dl>\n"; $content.= "\t<dt>Mainarticle? <dd>$main</dd></dt>\n"; $content.= "\t<td>What's the current date? <dd>$now</dd></dt>\n"; $content.= "\t<dt>Publication date less/equal today?<dd>$pub ($pub_date)</dd></dt>\n"; $content.= "\t<dt>Expiration date greater today? <dd>$exp ($exp_date)</dd></dt>\n"; $content.= "\t<dt>User may edit articles? <dd>$can_edit ($user)</dd></dt>\n"; $content.= "\t<dt>Current module is article? <dd>$modart</dd></dt>\n"; $content.= "\t<dt>Current module is approval? <dd>$modart</dd></dt>\n"; $content.= "\t<dt>Currently saving? <dd>$saving</dd></dt>\n"; $content.= "</dl>\n"; return($content); } ---------------------------------------------------------------------- Comment By: rck (rck000) Date: 2004-10-19 10:36 Message: Logged In: YES user_id=1035762 just had it again: Sorry! The article you requested is not viewable. ...can you make a more detailed error message, please? ---------------------------------------------------------------------- Comment By: Eloi George (adarkling) Date: 2004-10-18 02:11 Message: Logged In: YES user_id=619893 This issue is closed until we can figure out how to duplicate it or find other sites that it occurs on. ---------------------------------------------------------------------- Comment By: Yves Kuendig (ykuendig) Date: 2004-10-06 12:11 Message: Logged In: YES user_id=1000009 I've seen it at Ren page, the time i clicked the link to article 106 (emoticon-thread / phpwsforums). The page- framework has showed, but the body-part was blank. Becaus i was warned (from one of your forum-threads) i hit 'reload' and the page was showed normal with article. Yves ---------------------------------------------------------------------- Comment By: rck (rck000) Date: 2004-10-06 11:55 Message: Logged In: YES user_id=1035762 Thank you! I've postet it, you can find it at http://phpwsforums.com/viewtopic.php?p=962#962 ---------------------------------------------------------------------- Comment By: Eloi George (adarkling) Date: 2004-10-06 08:58 Message: Logged In: YES user_id=619893 You're right. I'll make the error messages more descriptive. I think you should post this question in the Modules fourm. If anyone else has seen this problem, maybe we can find out what the common variable is. ---------------------------------------------------------------------- Comment By: rck (rck000) Date: 2004-10-06 02:28 Message: Logged In: YES user_id=1035762 on thing that would help A LOT would be a nice error message. With the native mysql error. The next time, that error would happen on my site, we'd know for sure, where it was and what's going on... ---------------------------------------------------------------------- Comment By: rck (rck000) Date: 2004-10-06 02:12 Message: Logged In: YES user_id=1035762 In any case, it shouldn't delete the category, should it? I've never heard of a database being overloaded, either. It would only handles request slower that way. I haven't been writing about accessing articles at the same time. I've been writing about [i]new[/i] articles [i]sometimes [/i] being jumpy. And accessing them from the frontpage works everytime as well. So there must be some kind of weird bug somewhere. I could give you a couple of threads where this happened, but alas, they are all written german. This is the single most annoying bug in whole of phpWebSite I've experienced. Ever. And I had it right from the start, I had it again for an article this week (can't remember which), which hadn't even a lot hits. But it was new. This seems to matter... ---------------------------------------------------------------------- Comment By: Eloi George (adarkling) Date: 2004-10-04 09:21 Message: Logged In: YES user_id=619893 I don't know what could cause that to happen. I've never heard of it before. I tried to make it happen on your site by hitting it with 3 browsers at the same time, but everything worked perfectly! Most likely it's your database server. If it got overloaded and failed to return the data, you would get that error. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=681146&aid=1037668&group_id=81360 |
