[phpws-comm-auto] [ phpwebsite-comm-Support Requests-780810 ] Module Jobman: non-xhtml & in url

[SourceForge.net <no...@so...>]

Support Requests item #780810, was opened at 2003-07-31 08:19
Message generated for change (Comment added) made by gbrackett
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=563509&aid=780810&group_id=81360

Category: Module: jobman
Group: Second Level Support
Status: Open
Resolution: None
Priority: 6
Submitted By: Shaun Murray (singletrack)
Assigned to: George Brackett (gbrackett)
Summary: Module Jobman: non-xhtml & in url

Initial Comment:
In jobman/conf/boost...

$admin_op = "&JOB_MAN_op=list";


Should be

$admin_op = "&JOB_MAN_op=list";

Similarly for $user_op too.

----------------------------------------------------------------------

>Comment By: George Brackett (gbrackett)
Date: 2003-07-31 19:11

Message:
Logged In: YES 
user_id=398373

Okay, this problem is endemic, and I'll bring it to the
attention of the folks.  I did a search of all 2000+ files
in the current CVS and $admin_op is defined in essentially
ALL of the boost.php files in the same way I did it, using &
not &.  Here in the controlpanel.php file is where it
gets used:

	if (isset($admin_mod) && (bool)$admin_mod == TRUE){
	  $link->setURL("index.php?module=" . $mod_title . $admin_op);

So it's not only needed to create the URL, it should be
defined as you say with & not &.  Thanks!

----------------------------------------------------------------------

Comment By: George Brackett (gbrackett)
Date: 2003-07-31 18:33

Message:
Logged In: YES 
user_id=398373

Thanks, Shaun -- that helps.  I've done further research to
discover that in fact almost none of the other
conf/boost.php files that I can find in phpWS current CVS
even specify this variable (!), so I'm totally confused.  If
it's not specified here, how does phpWS know how to call the
module's main interface?  Hmm.  This bears further thought,
but meantime I shall of course make the changes you suggest.
 It's possible there are other &'s lurking, though...

----------------------------------------------------------------------

Comment By: Shaun Murray (singletrack)
Date: 2003-07-31 17:15

Message:
Logged In: YES 
user_id=722742

When you add jobman to a menu it inserts the URL in with a 
normal & to separate the parameters.

If you go run the page through the w3c validator it then fails on 
the jobman url in the menu. The validator is at http://
validator.w3.org/

In XHTML, &JOB_MAN is expected to be an entity you've defined 
earlier in your output. 

http://validator.w3.org/docs/errors.html#bad-entity suggests 
replacing & with & which much of the phpwebsite code does 
although there's a few normal & dotted about still. Jobman was 
just the only one I had left in my menu that did. You'll never see 
& in the URL you get in the address bar of your browser.



----------------------------------------------------------------------

Comment By: George Brackett (gbrackett)
Date: 2003-07-31 15:18

Message:
Logged In: YES 
user_id=398373

Could you tell me why?  This string will appear in a URL, as
you note, but the URLs I've seen don't have & in them. 
Does this generate an xhtml error for you?  What exactly is
the error, if so?  (This is probably a learning opportunity
for me, so be patient...)

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=563509&aid=780810&group_id=81360