From: SourceForge.net <no...@so...> - 2008-10-13 04:55:28
|
/mod/article item #2138556, was opened at 2008-09-30 12:42 Message generated for change (Comment added) made by adarkling You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=681146&aid=2138556&group_id=81360 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: None Group: None Status: Open Resolution: None Priority: 5 Private: No Submitted By: Tommy de Jesus (trf0000) Assigned to: Eloi George (adarkling) Summary: list articles in a group. Initial Comment: I think this is still a bit flawed as even dieties need to be in all groups to filter by group, but right now it looks at the wrong table. lines 57-58 $db->addWhere('phpws_key_view.group_id', $s_arr['groups']); $db->addWhere('phpws_key_view.key_id', 'article.key_id'); should be: $db->addWhere('phpws_key_edit.group_id', $s_arr['groups']); $db->addWhere('phpws_key_edit.key_id', 'article.key_id'); } Still for or diety access, all groups should display. for users that have unrestricted access, only the restricted groups they belong to should display. ---------------------------------------------------------------------- Comment By: Eloi George (adarkling) Date: 2008-10-13 00:55 Message: I've added an "Editable Articles Only" filter to the search menu. If you're going to check it out before 4.2 is released, make sure to apply the latest Key class patch (https://sourceforge.net/tracker2/?func=detail&aid=2162757&group_id=15539&atid=315539). ---------------------------------------------------------------------- Comment By: Tommy de Jesus (trf0000) Date: 2008-10-10 09:26 Message: When in the list of articles, it seems implied that the search is for editing. Well, it implied it to me. ---------------------------------------------------------------------- Comment By: Eloi George (adarkling) Date: 2008-10-09 18:40 Message: This code section is for searching articles that you're allowed to view, not edit. Did you want to suggest a search option for articles that the user is allowed to edit? ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=681146&aid=2138556&group_id=81360 |