phpweblog-devel

[phpWebLog-devel] Latest unstable Logic bug

[Alex C. <ac...@fo...>]

In common.inc.php

There is logic there to print the "read more XX comments",
but there is no code to read more if there are no comments.

So you will only be presented with the summary and no link to
the actual story.

My fix in common.inc.php

------ WAS ------
if (!empty($sum) && $CONF["Comments"]>0 && $ncmts>0) {
                $s      .= "\n<br>\n<br>\n<div \talign\t= right>\n";
                $s      .= sprintf("<small><a class=\"none\"
href=\"$G_URL/stori
es.php?story=%s\">\n",$A["Rid"]);
                $s      .= sprintf("read more (%s comments)
&gt;&gt;</a></small>
\n",$ncmts);
                $s      .= "<br><small>" . F_lastModified($A["Rid"]) .
"</small>
";
                $s      .= "</div></td>\n</tr>\n";

============================================================================
=========

------- Changed to ----------------

        if ($ncmts==0) {
                $s      .= "\n<br>\n<br>\n<div \talign\t= right>\n";
                $s      .= sprintf("<small><a class=\"none\"
href=\"$G_URL/stori
es.php?story=%s\">\n",$A["Rid"]);
                $s      .= "read more -- comment &gt;&gt;</a></small>\n";
                $s      .= "</div></td>\n</tr>\n";
        }

        elseif (!empty($sum) && $CONF["Comments"]>0 && $ncmts>0) {
                $s      .= "\n<br>\n<br>\n<div \talign\t= right>\n";
                $s      .= sprintf("<small><a class=\"none\"
href=\"$G_URL/stori
es.php?story=%s\">\n",$A["Rid"]);
                $s      .= sprintf("read more (%s comments)
&gt;&gt;</a></small>
\n",$ncmts);
                $s      .= "<br><small>" . F_lastModified($A["Rid"]) .
"</small>
";
                $s      .= "</div></td>\n</tr>\n";
        }

----------------------------------------------------

Re: [phpWebLog-devel] Latest unstable Logic bug

[Jason H. <ope...@ey...>]

Yes, I noticed this shortly after and fixed.. though I like your wording
better.

thanks alex.

jason

Alex Chun wrote:
> 
> In common.inc.php
> 
> There is logic there to print the "read more XX comments",
> but there is no code to read more if there are no comments.
> 
> So you will only be presented with the summary and no link to
> the actual story.
> 
> My fix in common.inc.php
> 
> ------ WAS ------
> if (!empty($sum) && $CONF["Comments"]>0 && $ncmts>0) {
>                 $s      .= "\n<br>\n<br>\n<div \talign\t= right>\n";
>                 $s      .= sprintf("<small><a class=\"none\"
> href=\"$G_URL/stori
> es.php?story=%s\">\n",$A["Rid"]);
>                 $s      .= sprintf("read more (%s comments)
> &gt;&gt;</a></small>
> \n",$ncmts);
>                 $s      .= "<br><small>" . F_lastModified($A["Rid"]) .
> "</small>
> ";
>                 $s      .= "</div></td>\n</tr>\n";
> 
> ============================================================================
> =========
> 
> ------- Changed to ----------------
> 
>         if ($ncmts==0) {
>                 $s      .= "\n<br>\n<br>\n<div \talign\t= right>\n";
>                 $s      .= sprintf("<small><a class=\"none\"
> href=\"$G_URL/stori
> es.php?story=%s\">\n",$A["Rid"]);
>                 $s      .= "read more -- comment &gt;&gt;</a></small>\n";
>                 $s      .= "</div></td>\n</tr>\n";
>         }
> 
>         elseif (!empty($sum) && $CONF["Comments"]>0 && $ncmts>0) {
>                 $s      .= "\n<br>\n<br>\n<div \talign\t= right>\n";
>                 $s      .= sprintf("<small><a class=\"none\"
> href=\"$G_URL/stori
> es.php?story=%s\">\n",$A["Rid"]);
>                 $s      .= sprintf("read more (%s comments)
> &gt;&gt;</a></small>
> \n",$ncmts);
>                 $s      .= "<br><small>" . F_lastModified($A["Rid"]) .
> "</small>
> ";
>                 $s      .= "</div></td>\n</tr>\n";
>         }
> 
> ----------------------------------------------------
> 
> _______________________________________________
> phpWebLog-devel mailing list
> php...@li...
> http://lists.sourceforge.net/mailman/listinfo/phpweblog-devel