Menu

#10 canadmin $_REQUEST var bug in admin.php

v1.3.0-preview-2
open
nobody
5
2005-06-10
2005-06-10
Danno
No

When un-checking the "This user has administrative
access" an error appears in the browser stating that
index canadmin not found. This is because the value of
'canadmin' is not returned if the checkbox is un-checked.

ORIGINAL CODE
-------------------------

if ( isset( $_REQUEST['update_worker'] ) )
{
$myworker = new Worker( $_REQUEST['worker_target'] );
$myworker->set_name( $_REQUEST['wname'] );
$myworker->set_admin( $_REQUEST['canadmin'] );
$myworker->update_db();
$myworker->modify_form( TEMPLATES_DIR . '/' . LANG
. '/' . EDIT_WORKER_TEMPLATE );
exit;
}

Here's a suggested fix that tests to see if the value
exists before assigning a value to tje set_admin function.

AMENDED
---------------

if ( isset( $_REQUEST['update_worker'] ) )
{
$myworker = new Worker( $_REQUEST['worker_target'] );
$myworker->set_name( $_REQUEST['wname'] );

if ( isset( $_REQUEST['canadmin'] ) )
{
$myworker->set_admin( $_REQUEST['canadmin'] );
}
else
{
$myworker->set_admin( 0 );
}
$myworker->update_db();
$myworker->modify_form( TEMPLATES_DIR . '/' . LANG
. '/' . EDIT_WORKER_TEMPLATE );
exit;
}

regards
Danno

Discussion


Log in to post a comment.