From: Steve D. <sd...@wo...> - 2004-11-05 19:14:41
|
Here's my minor changes, since I'm not gonna have time to finish this up today. http://sdibb.frogcircus.org/psa_20041105.tgz You can see the diffs by running rcsdiff -r1.1 -r1.2 * I also stole phpmyadmin's images and put them in img/ Also created a basic phpdocumenation from the SQLite class in phpdoc/ I think the class needs to be tweaked a little bit. I havent looked at all of it, but I don't like how on $class->query it returns an HTML error if there's a problem. I'd rather have it return bool true/false, and then output the error to an object variable, and be able to display it with another function (similar to PEAR's DB class). Steve |
From: Felipe L. <wi...@ig...> - 2004-11-08 03:05:14
|
>On Friday 05 November 2004 19:56, Steve Dibb wrote: >> Hey guys, > >Hi Steve, > Hi there! >> I'm working on an edit row patch right now. I've actually got it >> working, and I'll submit it once you can delete a row, too. > >Thats great news! > Indeed! >> The only bad side effect that I noticed is that SQLite doesn't allow >> the LIMIT clause when using DELETE or UPDATE unlike MySQL. Bummer. >> So what happens is when you update a row there's no way to tell it to >> limit it to one instance. The workaround I coded was to update the >> row where the old values match. That'll work, but it will also >> update/delete if there's more than one row. If you guys know a >> workaround to create a safety net, that'd be cool. Of course, it's a >> rare occurence it'd be needed, but still. > >well right now I don't know a real workaround for that... maybe we >should disable row edit/delete in case a table has no primary key, or >an other possibility would be to show an intermediary page that shows >the user which rows are to be updated/deleted (in case more than 1 row >would be affected) > IMO, we should lok for a primary key, if not found return error. >> The other thing is that in order to access SQLite through the web on >> linux, the database AND it's directory need to be world writeable. >> So I created a new directory named db and dumped phpsla.sqilte in >> there. > >very good idea, thank you! Good idea to organize things (including the other folders u created) > >> What's the best way to submit patches anyway? > >right now I'd say, send them to this list as an attachment. In case you >want to contribute regurlarly, using cvs would be the best. > >hope to hear from you soon, >Yves > >> Steve >> >> >> >> ------------------------------------------------------- >> This SF.Net email is sponsored by: >> Sybase ASE Linux Express Edition - download now for FREE >> LinuxWorld Reader's Choice Award Winner for best database on Linux. >> http://ads.osdn.com/?ad_id=5588&alloc_id=12065&op=click >> _______________________________________________ >> Phpsqliteadmin-devel mailing list >> Php...@li... >> https://lists.sourceforge.net/lists/listinfo/phpsqliteadmin-devel > >-- >Linux 2.6.8.1 #1 Sun Oct 31 11:27:19 CET 2004 i686 > 11:04:26 up 57 min, 1 user, load average: 2.13, 1.09, 1.22 > >------------------------------------------------------- >This SF.Net email is sponsored by: >Sybase ASE Linux Express Edition - download now for FREE >LinuxWorld Reader's Choice Award Winner for best database on Linux. >http://ads.osdn.com/?ad_id=5588&alloc_id=12065&op=click >_______________________________________________ >Phpsqliteadmin-devel mailing list >Php...@li... >https://lists.sourceforge.net/lists/listinfo/phpsqliteadmin-devel > >------- _________________________________________________________________________________ Quer mais velocidade? Só com o acesso Aditivado iG, a velocidade que você quer na hora que você precisa. Clique aqui: http://www.acessoaditivado.ig.com.br |
From: Yves G. <yg...@mi...> - 2004-11-07 10:16:13
|
On Friday 05 November 2004 20:14, Steve Dibb wrote: > Here's my minor changes, since I'm not gonna have time to finish this > up today. > > http://sdibb.frogcircus.org/psa_20041105.tgz > > You can see the diffs by running rcsdiff -r1.1 -r1.2 * thanks, will try to check it out asap > I also stole phpmyadmin's images and put them in img/ :-D > Also created a basic phpdocumenation from the SQLite class in phpdoc/ cool > I think the class needs to be tweaked a little bit. I havent looked > at all of it, but I don't like how on $class->query it returns an > HTML error if there's a problem. I'd rather have it return bool > true/false, and then output the error to an object variable, and be > able to display it with another function (similar to PEAR's DB > class). yes that's true. The class was and is a good idea, but it should be solid and clean. I have to admit that since some time I did not hack on phpsqliteadmin anymore, neither did Felipe. But we still love the project and I think that we should be able to restart development and release a new version if there are some new features. A new team member is great news for us! Do you plan to work more on a regular base on phpsla? cu, Yves > Steve > > > > ------------------------------------------------------- > This SF.Net email is sponsored by: > Sybase ASE Linux Express Edition - download now for FREE > LinuxWorld Reader's Choice Award Winner for best database on Linux. > http://ads.osdn.com/?ad_id=5588&alloc_id=12065&op=click > _______________________________________________ > Phpsqliteadmin-devel mailing list > Php...@li... > https://lists.sourceforge.net/lists/listinfo/phpsqliteadmin-devel -- Linux 2.6.8.1 #1 Sun Oct 31 11:27:19 CET 2004 i686 11:10:24 up 1:03, 1 user, load average: 2.70, 1.62, 1.33 |
From: Steve D. <sd...@wo...> - 2004-11-07 18:28:10
|
>>I think the class needs to be tweaked a little bit. I havent looked >>at all of it, but I don't like how on $class->query it returns an >>HTML error if there's a problem. I'd rather have it return bool >>true/false, and then output the error to an object variable, and be >>able to display it with another function (similar to PEAR's DB >>class). > > > yes that's true. The class was and is a good idea, but it should be > solid and clean. > > I have to admit that since some time I did not hack on phpsqliteadmin > anymore, neither did Felipe. > > But we still love the project and I think that we should be able to > restart development and release a new version if there are some new > features. A new team member is great news for us! > > Do you plan to work more on a regular base on phpsla? Yah, I'm planning on working on it quite a bit now. I'm ditching MySQL for SQLite, and I use phpMyAdmin a lot, so I really need a replacment tool. I think I can hack on it enough to get it working, so that's why I'm trying. I've already started changing a lot of stuff around, and I'll submit the changes when I have something that actually works. I've mostly just been cleaning up the code and adding some new functionality. I'm also working on a new class named PMA which stores the common functions. My coding style is usually that if there's anything I have to do more than once, I'll dump it in a function to save time. :) I'm also writing the new class so it's compatible with PhpDocumentor so I can generate a helpfile which explains everything. Ideally, what I would like to do, is use PEAR's DB class instead of the SQLite class included. The reason being that PEAR's class is already available publically, and has some great functionality, but it's sqlite support is a little weak. It would be great if we could submit patches to them using the old SQLite class, and whatever they don't accept, I can put in the PSA class instead. There's only a few areas whey their class is lacking (and I remember seeing a webpage once that described it's functionality for each database, but I couldnt find it) and they are mostly small things like getting the table information, getting the database information, etc. Stuff like that. It would need also stuff that's singular to SQLite like grabbing the schema, and we could add in our own class a way to alter tables by copying to temporary tables and stuff like that. As far as the look and feel, I don't know if you'll like all my changes or not -- I'm kind of modeling it after phpMyAdmin a bit since that's what I'm familiar with. I'm mostly just taking this of the approach of where it has the functionality I'd like to have, and then going back and cleaning it up to make it pretty. :) Steve |
From: Steve D. <sd...@wo...> - 2004-11-07 18:46:59
|
Here, its probably easier to show you what I'm up to, though it's halfway functional. :) uname: sdibb pwd: sdibb http://sdibb.frogcircus.org/psa/psa_20041107.tgz Steve |
From: Yves G. <yg...@mi...> - 2004-11-07 19:04:38
|
On Sunday 07 November 2004 18:47, Steve Dibb wrote: > Here, its probably easier to show you what I'm up to, though it's > halfway functional. :) wow, it looks great :-) are you using any IM as icq, that would make communication easier...? > uname: sdibb > pwd: sdibb > > http://sdibb.frogcircus.org/psa/psa_20041107.tgz > > Steve > > > ------------------------------------------------------- > This SF.Net email is sponsored by: > Sybase ASE Linux Express Edition - download now for FREE > LinuxWorld Reader's Choice Award Winner for best database on Linux. > http://ads.osdn.com/?ad_id=3D5588&alloc_id=3D12065&op=3Dclick > _______________________________________________ > Phpsqliteadmin-devel mailing list > Php...@li... > https://lists.sourceforge.net/lists/listinfo/phpsqliteadmin-devel =2D-=20 Linux 2.6.9 #1 Mon Nov 1 12:01:23 CET 2004 i686 20:03:31 up 41 min, 1 user, load average: 0.74, 0.72, 0.81 |
From: Yves G. <yg...@mi...> - 2004-11-10 11:12:42
|
On Friday 05 November 2004 20:14, Steve Dibb wrote: > Here's my minor changes, since I'm not gonna have time to finish this > up today. Hi Steve, > http://sdibb.frogcircus.org/psa_20041105.tgz I had half a day off this morning and took a deeper look into your work and I think we should include it into the phpsla cvs. I have just a few questions/propositions: * what is "import_request_variables("pg");" good for? At first sight I could not see any reason :-( * the symlink phpsla.sqlite -> db/phpsla.sqlite should go away and the code be changed to refer to "db/phpsla.sqlite" because of filesystems that don't support symlinks. I did the changes in my local tree. * I like the "require_once "inc.header.php";", it was longely overdue :-) * I like the class, it's overdue as well I'm sorry I took so much time, I really want phpsla to advance and so does Felipe. I should be able to find more free time for PHP soon. I also want to thank you very much in the name of Felipe and me for your work! cu soon, Yves p.s. If ever you are artistically talented... :-) phpsla needs a logo :-) > You can see the diffs by running rcsdiff -r1.1 -r1.2 * > > I also stole phpmyadmin's images and put them in img/ > > Also created a basic phpdocumenation from the SQLite class in phpdoc/ > > I think the class needs to be tweaked a little bit. I havent looked > at all of it, but I don't like how on $class->query it returns an > HTML error if there's a problem. I'd rather have it return bool > true/false, and then output the error to an object variable, and be > able to display it with another function (similar to PEAR's DB > class). > > Steve > > > > ------------------------------------------------------- > This SF.Net email is sponsored by: > Sybase ASE Linux Express Edition - download now for FREE > LinuxWorld Reader's Choice Award Winner for best database on Linux. > http://ads.osdn.com/?ad_id=5588&alloc_id=12065&op=click > _______________________________________________ > Phpsqliteadmin-devel mailing list > Php...@li... > https://lists.sourceforge.net/lists/listinfo/phpsqliteadmin-devel -- Linux 2.6.9 #1 Mon Nov 1 12:01:23 CET 2004 i686 11:23:07 up 1:03, 1 user, load average: 0.34, 0.08, 0.08 |
From: Steve D. <sd...@wo...> - 2004-11-10 15:05:34
|
> * what is "import_request_variables("pg");" good for? At first sight I > could not see any reason :-( import_request_variables dumps all $_GET and $_POST variables to their own variables. So if you have db.php?database=psa, a variable is automatically set for querystring $database to value $psa. It's the same as saying $_GET['database'], but without $_GET['...'] or $_POST['...']. Also a cool thing you can do with it is prepend variable names to the variables you're importing. For example: page: view.php?table=users&limit=50 code: import_request_variables("g", "psa_"); ("g" for get, "p" for post") result: $psa_table = "users", $psa_limit = 50; > * I like the "require_once "inc.header.php";", it was longely > overdue :-) > > * I like the class, it's overdue as well Well, like I said, there's still a lot I'm hacking on. Dont think of my change as final at all. Transitional to say the least. :) Steve |
From: Yves G. <yg...@mi...> - 2004-11-13 09:19:44
|
On Wednesday 10 November 2004 16:05, Steve Dibb wrote: > > * what is "import_request_variables("pg");" good for? At first > > sight I could not see any reason :-( > > import_request_variables dumps all $_GET and $_POST variables to > their own variables. So if you have db.php?database=psa, a variable > is automatically set for querystring $database to value $psa. It's > the same as saying $_GET['database'], but without $_GET['...'] or > $_POST['...']. OK I suspected that... ;-) I fact I always liked to user the $_GET['...'] and $_POST['...'] way of writing because you can immediataly see where the variable comes from, cookie, session, get or post, somehow they stay in their "namespace". > Also a cool thing you can do with it is prepend variable names to the > variables you're importing. > > For example: > > page: view.php?table=users&limit=50 > code: import_request_variables("g", "psa_"); ("g" for get, "p" for > post") result: $psa_table = "users", $psa_limit = 50; This is also a possibility to have some kind of "namespace" in the variable name... In that case we should probably have get_, post_, session_ and cookie_ as "prefix". If you could use that in your code it would be really appreciated :-) Maybe we can agree on either using the $_GET or $_POST notation, or in case you work with miport_request_variables, use the get_ and post_ notation. What do you think? (I know dbaction.php is bad in terms of code in that way, my bad...) > > * I like the "require_once "inc.header.php";", it was longely > > overdue :-) > > > > * I like the class, it's overdue as well > > Well, like I said, there's still a lot I'm hacking on. Dont think of > my change as final at all. Transitional to say the least. :) > > Steve > > > ------------------------------------------------------- > This SF.Net email is sponsored by: > Sybase ASE Linux Express Edition - download now for FREE > LinuxWorld Reader's Choice Award Winner for best database on Linux. > http://ads.osdn.com/?ad_id=5588&alloc_id=12065&op=click > _______________________________________________ > Phpsqliteadmin-devel mailing list > Php...@li... > https://lists.sourceforge.net/lists/listinfo/phpsqliteadmin-devel -- Linux 2.6.9 #1 Mon Nov 1 12:01:23 CET 2004 i686 10:07:47 up 12:16, 1 user, load average: 1.04, 0.71, 0.62 |