Re: [Phpsqliteadmin-devel] edit row patch

[Yves G. <yg...@mi...>]

On Friday 05 November 2004 20:14, Steve Dibb wrote:
> Here's my minor changes, since I'm not gonna have time to finish this
> up today.

Hi Steve,

> http://sdibb.frogcircus.org/psa_20041105.tgz

I had half a day off this morning and took a deeper look into your work 
and I think we should include it into the phpsla cvs.

I have just a few questions/propositions:

* what is "import_request_variables("pg");" good for? At first sight I 
could not see any reason :-(

* the symlink phpsla.sqlite -> db/phpsla.sqlite should go away and the 
code be changed to refer to "db/phpsla.sqlite" because of filesystems 
that don't support symlinks. I did the changes in my local tree.

* I like the "require_once "inc.header.php";", it was longely 
overdue :-)

* I like the class, it's overdue as well


I'm sorry I took so much time, I really want phpsla to advance and so 
does Felipe. I should be able to find more free time for PHP soon.

I also want to thank you very much in the name of Felipe and me for your 
work!

cu soon,
Yves


p.s.
If ever you are artistically talented... :-) phpsla needs a logo :-)


> You can see the diffs by running rcsdiff -r1.1 -r1.2 *
>
> I also stole phpmyadmin's images and put them in img/
>
> Also created a basic phpdocumenation from the SQLite class in phpdoc/
>
> I think the class needs to be tweaked a little bit.  I havent looked
> at all of it, but I don't like how on $class->query it returns an
> HTML error if there's a problem.  I'd rather have it return bool
> true/false, and then output the error to an object variable, and be
> able to display it with another function (similar to PEAR's DB
> class).
>
> Steve
>
>
>
> -------------------------------------------------------
> This SF.Net email is sponsored by:
> Sybase ASE Linux Express Edition - download now for FREE
> LinuxWorld Reader's Choice Award Winner for best database on Linux.
> http://ads.osdn.com/?ad_id=5588&alloc_id=12065&op=click
> _______________________________________________
> Phpsqliteadmin-devel mailing list
> Php...@li...
> https://lists.sourceforge.net/lists/listinfo/phpsqliteadmin-devel

-- 
Linux 2.6.9 #1 Mon Nov 1 12:01:23 CET 2004 i686
 11:23:07 up  1:03,  1 user,  load average: 0.34, 0.08, 0.08