Re: [Phpsqliteadmin-devel] edit row patch

[Steve D. <sd...@wo...>]

>>I think the class needs to be tweaked a little bit.  I havent looked
>>at all of it, but I don't like how on $class->query it returns an
>>HTML error if there's a problem.  I'd rather have it return bool
>>true/false, and then output the error to an object variable, and be
>>able to display it with another function (similar to PEAR's DB
>>class).
> 
> 
> yes that's true. The class was and is a good idea, but it should be 
> solid and clean.
> 
> I have to admit that since some time I did not hack on phpsqliteadmin 
> anymore, neither did Felipe.
> 
> But we still love the project and I think that we should be able to 
> restart development and release a new version if there are some new 
> features. A new team member is great news for us!
> 
> Do you plan to work more on a regular base on phpsla?

Yah, I'm planning on working on it quite a bit now.  I'm ditching MySQL 
for SQLite, and I use phpMyAdmin a lot, so I really need a replacment 
tool.  I think I can hack on it enough to get it working, so that's why 
I'm trying.

I've already started changing a lot of stuff around, and I'll submit the 
changes when I have something that actually works.  I've mostly just 
been cleaning up the code and adding some new functionality.  I'm also 
working on a new class named PMA which stores the common functions.  My 
coding style is usually that if there's anything I have to do more than 
once, I'll dump it in a function to save time. :)  I'm also writing the 
new class so it's compatible with PhpDocumentor so I can generate a 
helpfile which explains everything.

Ideally, what I would like to do, is use PEAR's DB class instead of the 
SQLite class included.  The reason being that PEAR's class is already 
available publically, and has some great functionality, but it's sqlite 
support is a little weak.  It would be great if we could submit patches 
to them using the old SQLite class, and whatever they don't accept, I 
can put in the PSA class instead.  There's only a few areas whey their 
class is lacking (and I remember seeing a webpage once that described 
it's functionality for each database, but I couldnt find it) and they 
are mostly small things like getting the table information, getting the 
database information, etc.  Stuff like that.  It would need also stuff 
that's singular to SQLite like grabbing the schema, and we could add in 
our own class a way to alter tables by copying to temporary tables and 
stuff like that.

As far as the look and feel, I don't know if you'll like all my changes 
or not -- I'm kind of modeling it after phpMyAdmin a bit since that's 
what I'm familiar with.  I'm mostly just taking this of the approach of 
where it has the functionality I'd like to have, and then going back and 
  cleaning it up to make it pretty. :)

Steve