Re: FW: [phpslash-users] column sensing patch

[Joe S. <jo...@be...>]

Peter,

Worked nicely.  I'm not very good with patches, but I was able to
edit existing pages with your changes.

I've made a couple of tweaks here and there but have it ready to go.

Made it transparent for now if no columns are specified.  I like the
ability to go to one column, but for the people upgrading it would throw
them off.  Comments?

Moved the related links back up to the top right if that column exists,
 just to keep backwards compat.

Any problems from using the same template for the article and index pages?
We never distributed a 3 column article page anyway.  A few people have
gotten one from me directly.

It's cool that some sections can be 3 columns while another would be 2.

Anyway its in cvs now for testing.  As Ajay and Nathan tell me, it's easy
enough to back out the changes.

thanks,

Joe

On Mon, Jan 07, 2002 at 08:20:10PM -0000, Peter Cruickshank wrote:
> 
> > On Fri, 4 Jan 2002, Joe Stewart wrote:
> >
> > > > I've changed index.php3 and article.php3 to check for
> > existence of blocks in
> > > > columns "left", "center" and "right" and then automatically
> > switch between
> > > > 1,2 or 3 column display (using four shared templates). Is it
> > worth uploading
> > > > or mailing to this list?
> > > >
> > >
> > > Ajay?
> >
> > Maybe you should create a patch against 0.65 and upload it to the
> > sourceforge site?
> 
> Now done. It's the first time I've posted a patch so any
> comments/suggestions would be appreciated.
> 
> Cheers
> 
> Peter
> 
> (Ajay - I replied to you email at first, so you'll have an extra copy.
> Sorry)
> 
>